Fix name extraction#67
Open
apple-phi wants to merge 1 commit into
Open
Conversation
Owner
|
Looks good. Thank you! Do you think you could add the newly supported formats as test cases in tests/gedcom.spec.ts? |
Author
|
@PeWu Sure, can do—but actually, now that I think about it, is there any reason to split out the forename and surname in the first place? Shouldn't topola just respect the ordering and naming of the individual, as given in the file? Because GEDCOM is designed to be flexible and allow all name orderings and conventions, whatever that might be in the individual's culture. Because I've realised that if I get this PR merged, I'll soon probably have to make a PR to let the user choose the name ordering, but this seems like reinventing the wheel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #66