Skip to content

perf: skip dedup map in getChildrenNodes #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jvoisin wants to merge 1 commit into
base: master
Choose a base branch
from
+16 −3
Open

perf: skip dedup map in getChildrenNodes #570

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions traversal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -604,9 +604,22 @@ func getSiblingNodes(nodes []*html.Node, st siblingType, untilm Matcher, untilNo
// Gets the children nodes of each node in the specified slice of nodes,
// based on the sibling type request.
func getChildrenNodes(nodes []*html.Node, st siblingType) []*html.Node {
return mapNodes(nodes, func(i int, n *html.Node) []*html.Node {
return getChildrenWithSiblingType(n, st, nil, nil)
})
// Each child has exactly one parent, so the children of distinct source
// nodes form disjoint sets: there is nothing to deduplicate across them.
// Skip mapNodes' per-call dedup map and append directly, while keeping the
// single-node fast path that returns the slice without an extra copy.
switch len(nodes) {
case 0:
return nil
case 1:
return getChildrenWithSiblingType(nodes[0], st, nil, nil)
}

var result []*html.Node
for _, n := range nodes {
result = append(result, getChildrenWithSiblingType(n, st, nil, nil)...)
}
return result
}

// Gets the children of the specified parent, based on the requested sibling
Expand Down
Loading