perf: inline dedup loop in getParentNodes#572
Open
jvoisin wants to merge 1 commit into
Open
Conversation
getParentNodes routed Parent/ParentFiltered through mapNodes with a
closure returning a one-element []*html.Node{n.Parent} per source node.
On a sibling selection nearly all of those slices point at the same
parent and are immediately deduped away.
This commit walks s.Nodes directly instead: for a single node, return its
parent with no map; for many, dedup parents into a shared set while appending.
This removes the per-node slice allocation at the source rather than cleaning
it up downstream.
benchstat (count=10, all p=0.000):
allocs/op Parent 384->7 (-98%), ParentFiltered 392->16 (-96%)
sec/op Parent -78%, ParentFiltered -59%
B/op both -22%
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getParentNodes routed Parent/ParentFiltered through mapNodes with a closure returning a one-element []*html.Node{n.Parent} per source node. On a sibling selection nearly all of those slices point at the same parent and are immediately deduped away.
This commit walks s.Nodes directly instead: for a single node, return its parent with no map; for many, dedup parents into a shared set while appending. This removes the per-node slice allocation at the source rather than cleaning it up downstream.
benchstat (count=10, all p=0.000):
allocs/op Parent 384->7 (-98%), ParentFiltered 392->16 (-96%)
sec/op Parent -78%, ParentFiltered -59%
B/op both -22%