Fix post-oxidization change in ConsolidateBlocks behavior (backport #13450)#13453
Merged
Conversation
* Set decomposer to None if kak_gates not found during ConsolidateBlocks initialization. * Add test that reproduces issue * Re-add rzz to list of kak gates * Add path for rzx gate. (cherry picked from commit 94cea41)
Collaborator
|
Thank you for opening a new pull request. Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone. One or more of the following people are relevant to this code:
|
github-actions
Bot
added
the
Changelog: None
Pull Request Test Coverage Report for Build 11903054996Details
💛 - Coveralls |
ElePT
approved these changes
Nov 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the behavioral difference introduced by #13368 that caused #13438.
The original implementation of the pass used to set the
ConsolidateBlocksinternal decomposer callingunitary_synthesis._decomposer_2q_from_basis_gates, which, whenkak_basiswasn't found, would returnNone. During the oxidization efforts,unitary_synthesis._decomposer_2q_from_basis_gateswas replaced with inline code that didn't contemplate this path (always set a default decomposer), which in the reproducing example lead to a longer output circuit (the gates were collected into a unitary block and then decomposed differently).Details and comments
Technically not a bugfix because the change wasn't released yet.
Using the example shown in the issue ->
ConsolidateBlocksoutput dag with 1.2.4:ConsolidateBlocksoutput dag with 1.3.0rc1:ConsolidateBlocksoutput dag after this fix:This is an automatic backport of pull request #13450 done by [Mergify](https://mergify.com).