Improve ConsolidateBlocks documentation#15890
Open
mtreinish wants to merge 4 commits into
Open
Conversation
The consolidate blocks transpiler pass was lacking concrete documentation on it's operation. Especially for how it iteracted with other passes and specific property set fields. This commit aims to close that gap and explicitly document how the pass behaves, both in the expected current configuration as well as the still supported legacy operation modes.
Collaborator
|
One or more of the following people are relevant to this code:
|
mtreinish
added
documentation
Co-authored-by: Shelly Garion <46566946+ShellyGarion@users.noreply.github.com> Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Coverage Report for CI Build 26668505362Coverage decreased (-0.002%) to 87.554%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions17 previously-covered lines in 3 files lost coverage.
Coverage Stats
💛 - Coveralls |
ShellyGarion
approved these changes
May 31, 2026
Member
ShellyGarion
left a comment
ShellyGarion
left a comment
There was a problem hiding this comment.
LGTM. @Cryoris - do you have any comments or could we merge this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The consolidate blocks transpiler pass was lacking concrete documentation on it's operation. Especially for how it iteracted with other passes and specific property set fields. This commit aims to close that gap and explicitly document how the pass behaves, both in the expected current configuration as well as the still supported legacy operation modes.
Details and comments