Use rust-native error for RemoveIdentityEquiv #16195
Open
raynelfss wants to merge 2 commits into
Open
Conversation
Use rust-native errors in `DAGCircuit` This should be step 1 for splitting `PyDAGCircuit` from `DAGCircuit`. The following commits assure that any rust accessible method for `DAGCircuit` that: 1. Does not take a `py` token; 2. Is a public method. does not need to depend on `PyErr` to process any errors. It is ensured that these errors: - Maintain the level of detail that the previous ones did. - Correctly map to the same Python exceptions as before. The enumeration for these errors is called `DAGCircuitInnerError` (subject to change) and is implemented with `thiserror`. I chose this over `anyhow` because it is better for specifying where the error comes from based on its variant rather than the message it contains. Lint: Use names instead of underscores Add: `anyhow!` usage for `DAGCircuitError - Use `anyhow!` for any error types that don't require tracking of any variables coming from the `DAG` or that are part of the function arguments. - Consolidate the amount of `DAG` error variants down from 40+ to 21. Can be consolidated further. Fix: Existing error formatting - Use `this_error` to fix the formatting of current errors causing conflicts with their messages. - Add `is_var` argument to differentiate Variables and Stretches in `VariableNotInlined`. Fix: consolidate `RegistryAbsentObject` error. Add: errors for `size` and `depth`.
The following commits modify `RemoveIdentityEquiv` to use rust-native errors throughout its pipeline. In this PR we introduce the error enumeration `RemoveIdentityEquivEerror` which only has two variants, one for `DAGCircuitError` and the other is for a specific case involving `PauliEvolution` gates that only exist in Python currently. These changes mostly depend on Qiskit#16134.
raynelfss
added
on hold
Collaborator
|
One or more of the following people are relevant to this code:
|
Coverage Report for CI Build 25964281920Coverage decreased (-0.01%) to 87.699%Details
Uncovered Changes
Coverage Regressions29 previously-covered lines in 6 files lost coverage.
Coverage Stats
💛 - Coveralls |
6 tasks
gadial
approved these changes
May 17, 2026
Contributor
gadial
left a comment
gadial
left a comment
There was a problem hiding this comment.
Looks good to me.
My only question is whether the .map_err(RemoveIdentityEquivError::PyPauliRotationTraceAndDim)?; can be avoided by more implicit conversion, and whether it should be avoided like this. But it's a very minor concern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following commits modify
RemoveIdentityEquivto use rust-native errors throughout its pipeline.In this PR we introduce the error enumeration
RemoveIdentityEquivEerrorwhich only has two variants, one forDAGCircuitErrorand the other is for a specific case involvingPauliEvolutiongates that only exist in Python currently.Use this to visualize the actual diff
Pre-requisites
DAGCircuit#16134AI/LLM disclosure