Make builtin qasm2.CustomClassical extensions Rust-native#16202
Draft
jeevan0920 wants to merge 2 commits into
Draft
Make builtin qasm2.CustomClassical extensions Rust-native#16202jeevan0920 wants to merge 2 commits into
jeevan0920 wants to merge 2 commits into
Conversation
Collaborator
|
One or more of the following people are relevant to this code:
|
Coverage Report for CI Build 26281746248Coverage increased (+0.02%) to 87.51%Details
Uncovered Changes
Coverage Regressions10 previously-covered lines in 2 files lost coverage.
Coverage Stats
💛 - Coveralls |
Collaborator
|
Hi Jeevan, could you document this PR a bit? What does this implement on top of #15560? And if this a draft, then we can mark it as such so we don't run the full CI on every commit. |
Contributor
Author
Hi Julien, it is still work in progress, thanks for pointing out about the CI, I did not know about the draft PR thing. |
f549267 to
e4dc0fc
Compare
e4dc0fc to
934dc08
Compare
934dc08 to
40b251a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is aimed at completing the PR at https://github.com/Qiskit/qiskit/pull/15560/changes