Skip to content

Make builtin qasm2.CustomClassical extensions Rust-native#16202

Draft
jeevan0920 wants to merge 2 commits into
Qiskit:mainfrom
jeevan0920:jeevan/pr-15560-contd-1
Draft

Make builtin qasm2.CustomClassical extensions Rust-native#16202
jeevan0920 wants to merge 2 commits into
Qiskit:mainfrom
jeevan0920:jeevan/pr-15560-contd-1

Conversation

@jeevan0920
Copy link
Copy Markdown
Contributor

@jeevan0920 jeevan0920 commented May 18, 2026

This PR is aimed at completing the PR at https://github.com/Qiskit/qiskit/pull/15560/changes

@jeevan0920 jeevan0920 requested a review from a team as a code owner May 18, 2026 08:36
@jeevan0920 jeevan0920 requested a review from Cryoris May 18, 2026 08:36
@qiskit-bot
Copy link
Copy Markdown
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core

@coveralls
Copy link
Copy Markdown

coveralls commented May 20, 2026

Coverage Report for CI Build 26281746248

Coverage increased (+0.02%) to 87.51%

Details

  • Coverage increased (+0.02%) from the base build.
  • Patch coverage: 11 uncovered changes across 2 files (209 of 220 lines covered, 95.0%).
  • 10 coverage regressions across 2 files.

Uncovered Changes

File Changed Covered %
crates/qasm2/src/bytecode.rs 122 112 91.8%
crates/qasm2/src/ext.rs 50 49 98.0%

Coverage Regressions

10 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
crates/qasm2/src/parse.rs 6 97.62%
crates/qasm2/src/lex.rs 4 92.03%

Coverage Stats

Coverage Status
Relevant Lines: 123978
Covered Lines: 108493
Line Coverage: 87.51%
Coverage Strength: 957838.68 hits per line

💛 - Coveralls

@Cryoris
Copy link
Copy Markdown
Collaborator

Cryoris commented May 20, 2026

Hi Jeevan, could you document this PR a bit? What does this implement on top of #15560? And if this a draft, then we can mark it as such so we don't run the full CI on every commit.

@jeevan0920 jeevan0920 marked this pull request as draft May 21, 2026 04:46
@jeevan0920
Copy link
Copy Markdown
Contributor Author

Hi Jeevan, could you document this PR a bit? What does this implement on top of #15560? And if this a draft, then we can mark it as such so we don't run the full CI on every commit.

Hi Julien, it is still work in progress, thanks for pointing out about the CI, I did not know about the draft PR thing.

@jeevan0920 jeevan0920 force-pushed the jeevan/pr-15560-contd-1 branch from f549267 to e4dc0fc Compare May 21, 2026 13:55
@jeevan0920 jeevan0920 changed the title [WIP] Jeevan/pr 15560 contd 1 [WIP] PR 15560 Contd May 21, 2026
@jeevan0920 jeevan0920 force-pushed the jeevan/pr-15560-contd-1 branch from e4dc0fc to 934dc08 Compare May 22, 2026 10:08
@jeevan0920 jeevan0920 changed the title [WIP] PR 15560 Contd Make builtin qasm2.CustomClassical extensions Rust-native May 22, 2026
@jeevan0920 jeevan0920 force-pushed the jeevan/pr-15560-contd-1 branch from 934dc08 to 40b251a Compare May 22, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants