Remove QPY warning on deserialising incomplete ParameterVectors#16222
Open
jakelishman wants to merge 1 commit into
Open
Remove QPY warning on deserialising incomplete ParameterVectors#16222jakelishman wants to merge 1 commit into
ParameterVectors#16222jakelishman wants to merge 1 commit into
Conversation
jakelishman
added
on hold
jakelishman
force-pushed
the
no-warn-vector-qpy
branch
from
d14a9dd to
8e4b783
Compare
Coverage Report for CI Build 26261117365Coverage decreased (-0.004%) to 87.49%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions12 previously-covered lines in 3 files lost coverage.
Coverage Stats
💛 - Coveralls |
This was referenced May 21, 2026
This warning was added with QPY v3[^1] at a time when `ParameterVector` generated all its elements with unrelated UUIDs. Since `qiskit-terra` v0.25, we actually _have_ had enough information to completely recreate an entire vector from a single element[^2], and the circumstances needed to observe the incomplete behaviour are particularly convoluted, and unlikely in practice. [^1]: 5c4cd2b: Fix ParameterVector handling in QPY serialization (Qiskitgh-7381) [^2]: 5ab231d: Slightly optimize ParameterVector construction (Qiskitgh-10403)
jakelishman
force-pushed
the
no-warn-vector-qpy
branch
from
8e4b783 to
41a35f5
Compare
Collaborator
|
One or more of the following people are relevant to this code:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This warning was added with QPY v31 at a time when
ParameterVectorgenerated all its elements with unrelated UUIDs. Sinceqiskit-terrav0.25, we actually have had enough information to completely recreate an entire vector from a single element2, and the circumstances needed to observe the incomplete behaviour are particularly convoluted, and unlikely in practice.Based on #16221.
The circumstances you can observe the bad behaviour are in the release note - it's pretty convoluted once #16221 is in place. I've separated off this PR from the others to discuss whether we truly want this. I think, with #16221 merged, the warning is no longer serving a meaningful purpose, and it costs us to maintain the tracking for it.
AI/LLM disclosure
Footnotes
5c4cd2b: Fix ParameterVector handling in QPY serialization (Fix ParameterVector handling in QPY serialization #7381) ↩
5ab231d: Slightly optimize ParameterVector construction (Slightly optimize ParameterVector construction #10403) ↩