Perform ConsolidateBlocks analysis in parallel#16230
Open
mtreinish wants to merge 1 commit into
Open
Conversation
This commit updates the ConsolidateBlocks transpiler pass to internally be multithreaded. It will run the analysis of blocks in parallel and make the determination on whether to do a consolidation or not and collect that result into an intermediate vector. Then serially we'll iterate over the vector and update the dag based on the result of the analysis. This speeds up the runtime performance of the pass especially as the analysis is the more computationally expensive part of the pass. This change is still relevant even after Qiskit#16136 merges as the new TwoQubitPeepholeOptimization pass is only being used to replace the use of ConsolidateBlocks in the optimization loop. We still run the pass as part of the init stage by default and this will speed up that execution.
mtreinish
added
performance
Rust
Collaborator
|
One or more of the following people are relevant to this code:
|
Coverage Report for CI Build 26249064185Coverage increased (+0.02%) to 87.502%Details
Uncovered Changes
Coverage Regressions5 previously-covered lines in 4 files lost coverage.
Coverage Stats
💛 - Coveralls |
Member
Author
|
I ran asv to compare the performance with this PR vs not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the ConsolidateBlocks transpiler pass to internally be multithreaded. It will run the analysis of blocks in parallel and make the determination on whether to do a consolidation or not and collect that result into an intermediate vector. Then serially we'll iterate over the vector and update the dag based on the result of the analysis. This speeds up the runtime performance of the pass especially as the analysis is the more computationally expensive part of the pass.
This change is still relevant even after #16136 merges as the new TwoQubitPeepholeOptimization pass is only being used to replace the use of ConsolidateBlocks in the optimization loop. We still run the pass as part of the init stage by default and this will speed up that execution.
AI/LLM disclosure