Skip to content

Fix QPY scoped cache uploads in GitHub Actions#16315

Open
jakelishman wants to merge 1 commit into
Qiskit:mainfrom
jakelishman:qpy-cache
Open

Fix QPY scoped cache uploads in GitHub Actions#16315
jakelishman wants to merge 1 commit into
Qiskit:mainfrom
jakelishman:qpy-cache

Conversation

@jakelishman
Copy link
Copy Markdown
Member

When we consolidated the branch-protection rules1, we removed the on: push logic from all the jobs too, to avoid duplication of unnecessary work. This has the knock-on effect of preventing the QPY cache from getting populated into a cache scope2 that's reachable from later PRs and the merge queue, and so all the QPY jobs have been taking a lot longer than necessary recently.


I'm not entirely confident in this, but it's hard to check without merging to main.

AI/LLM disclosure

  • I didn't use LLM tooling, or only used it privately.
  • I used the following tool to help write this PR description:
  • I used the following tool to generate or modify code:

Footnotes

  1. 913091b: Unify GitHub Actions branch-protection run logic (Unify GitHub Actions branch-protection run logic #15794)

  2. https://docs.github.com/en/actions/reference/workflows-and-actions/dependency-caching#restrictions-for-accessing-a-cache

When we consolidated the branch-protection rules[^1], we removed the
`on: push` logic from all the jobs too, to avoid duplication of
unnecessary work.  This has the knock-on effect of preventing the QPY
cache from getting populated into a cache scope[^2] that's reachable
from later PRs and the merge queue, and so all the QPY jobs have been
taking a lot longer than necessary recently.

[^1]: 913091b: Unify GitHub Actions branch-protection run logic (Qiskitgh-15794)
[^2]: https://docs.github.com/en/actions/reference/workflows-and-actions/dependency-caching#restrictions-for-accessing-a-cache
@jakelishman jakelishman requested a review from a team as a code owner May 29, 2026 17:09
@jakelishman jakelishman added type: qa Issues and PRs that relate to testing and code quality stable backport potential Make Mergify open a backport PR to the most recent stable branch on merge. Changelog: None Do not include in the GitHub Release changelog. labels May 29, 2026
@qiskit-bot
Copy link
Copy Markdown
Collaborator

One or more of the following people are relevant to this code:

  • @Qiskit/terra-core
  • @mtreinish

@coveralls
Copy link
Copy Markdown

Coverage Report for CI Build 26651179134

Coverage increased (+0.01%) to 87.526%

Details

  • Coverage increased (+0.01%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 15 coverage regressions across 4 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

15 previously-covered lines in 4 files lost coverage.

File Lines Losing Coverage Coverage
crates/qasm2/src/parse.rs 6 97.15%
crates/circuit/src/parameter/symbol_expr.rs 5 74.13%
crates/qasm2/src/lex.rs 3 92.29%
crates/circuit/src/parameter/parameter_expression.rs 1 91.04%

Coverage Stats

Coverage Status
Relevant Lines: 123926
Covered Lines: 108467
Line Coverage: 87.53%
Coverage Strength: 963077.39 hits per line

💛 - Coveralls

@jakelishman
Copy link
Copy Markdown
Member Author

Wait, I'm actually not sure what happens here if the required inputs from the workflow_call aren't present. I need to check that and probably think about an alternative strategy.

@jakelishman jakelishman added the on hold Can not fix yet label May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changelog: None Do not include in the GitHub Release changelog. on hold Can not fix yet stable backport potential Make Mergify open a backport PR to the most recent stable branch on merge. type: qa Issues and PRs that relate to testing and code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants