Fix QPY scoped cache uploads in GitHub Actions#16315
Open
jakelishman wants to merge 1 commit into
Open
Conversation
When we consolidated the branch-protection rules[^1], we removed the `on: push` logic from all the jobs too, to avoid duplication of unnecessary work. This has the knock-on effect of preventing the QPY cache from getting populated into a cache scope[^2] that's reachable from later PRs and the merge queue, and so all the QPY jobs have been taking a lot longer than necessary recently. [^1]: 913091b: Unify GitHub Actions branch-protection run logic (Qiskitgh-15794) [^2]: https://docs.github.com/en/actions/reference/workflows-and-actions/dependency-caching#restrictions-for-accessing-a-cache
Collaborator
|
One or more of the following people are relevant to this code:
|
Coverage Report for CI Build 26651179134Coverage increased (+0.01%) to 87.526%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions15 previously-covered lines in 4 files lost coverage.
Coverage Stats
💛 - Coveralls |
Member
Author
|
Wait, I'm actually not sure what happens here if the required inputs from the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we consolidated the branch-protection rules1, we removed the
on: pushlogic from all the jobs too, to avoid duplication of unnecessary work. This has the knock-on effect of preventing the QPY cache from getting populated into a cache scope2 that's reachable from later PRs and the merge queue, and so all the QPY jobs have been taking a lot longer than necessary recently.I'm not entirely confident in this, but it's hard to check without merging to
main.AI/LLM disclosure
Footnotes
913091b: Unify GitHub Actions branch-protection run logic (Unify GitHub Actions branch-protection run logic #15794) ↩
https://docs.github.com/en/actions/reference/workflows-and-actions/dependency-caching#restrictions-for-accessing-a-cache ↩