Add rust-native circuit erorrs to BasisTranslator#16318
Open
raynelfss wants to merge 1 commit into
Open
Conversation
- The basis translator currently uses the `BasisTranslatorError` enum to supply all of the possible errors originating in the `BasisTranslator` pass. We had the errorss `BasisCircuitError` and `BasisDAGCircuitError` to handle the py errors used within `CircuitData` and `DAGCircuit`. The following commit changes that behavior to use the rust-native `CircuitDataError` and `DAGError` as their bases but also performs the following changes:
- Rename `BasisCircuitError` to `Circuit`, and `BasisDAGCircuitError` to `DAGCircuit`.
- Add a `PyGate` specific error.
- This error does not implement `From<PyErr>` because we don't want to implicitly pass a `Python` error coming from somewhere else. By manually mapping, we know exactly where it originates.
raynelfss
added
the
Changelog: None
raynelfss
added
Rust
Collaborator
|
One or more of the following people are relevant to this code:
|
Coverage Report for CI Build 26653369099Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage increased (+0.04%) to 87.56%Details
Uncovered Changes
Coverage Regressions14 previously-covered lines in 4 files lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basis translator currently uses the
BasisTranslatorErrorenum to supply all of the possible errors originating in theBasisTranslatorpass. We had the errorssBasisCircuitErrorandBasisDAGCircuitErrorto handle the py errors used withinCircuitDataandDAGCircuit. The following commit changes that behavior to use the rust-nativeCircuitDataErrorandDAGErroras their bases but also performs the following changes:BasisCircuitErrortoCircuit, andBasisDAGCircuitErrortoDAGCircuit.PyGatespecific error.From<PyErr>because we don't want to implicitly pass aPythonerror coming from somewhere else. By manually mapping, we know exactly where it originates.AI/LLM disclosure