add production GEMM tests#590
Conversation
f3b9d08 to
c4c2ea5
Compare
| switch (s.pass) { | ||
| case GemmPass::FWD: | ||
| case GemmPass::DGRAD: | ||
| m = tokens; n = s.dim1; k = s.dim2; break; |
There was a problem hiding this comment.
nit: I think break should go on its own line for readability here.
ipanfilo
left a comment
There was a problem hiding this comment.
Please write the changes description. Also, why production LLM shapes cannot be added to existing gemm test?
Added, thanks.
My thinking was that we can run just these particular tests "standalone", without the other GEMM tests, on (say) a new architecture, for testing. |
It the difference is only in usage, can it be added just with different prefix or as different suite: INSTANTIATE_TEST_SUITE_P(OperatorTest, GEMMTestSuite) so they can easy be run separately ? |
Description
Add production-like GEMM tests for Qwen3 and Deepseek3.
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: