Added babel plugin to support numeric separators in test files#224
Open
ojaoc wants to merge 1 commit into
Open
Added babel plugin to support numeric separators in test files#224ojaoc wants to merge 1 commit into
ojaoc wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When parsing test files that use numeric separators, for intance:
const numberWithSeparators = 3_600_000;The babel parser throws an error
Identifier directly after number.In my case, this resulted in the omission of a failed test's result.
I fixed this by adding @babel/plugin-proposal-numeric-separator to the plugin list.