fix(meteor): useMemo side-effect in RoomsTable

[TasfinMahmud]

Fixes #40589 by extracting the setCurrent(0) side effect from useMemo into useEffect where state mutations belong, ensuring pure computation and respecting React's rendering contract.

Summary by CodeRabbit

Release Notes

• Bug Fixes
  • Fixed pagination behavior in the admin rooms table to properly reset to the first page when filtering by search text.

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is missing the 'stat: QA assured' label
• This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: fc8f3f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 0727cb03-867d-4b26-a6f8-72a73a792b64

📥 Commits

Reviewing files that changed from the base of the PR and between 2d39044 and ae69f88.

📒 Files selected for processing (1)

• apps/meteor/client/views/admin/rooms/RoomsTable.tsx

🚧 Files skipped from review as they are similar to previous changes (1)

• apps/meteor/client/views/admin/rooms/RoomsTable.tsx

---

Walkthrough

RoomsTable pagination behavior is refactored to reset pagination state when searchText changes. The conditional setCurrent(0) call is removed from the useMemo query builder, the dependency array is updated, and a dedicated useEffect is added to properly reset pagination and track filter changes.

Changes

RoomsTable Pagination Side Effect Fix

Layer / File(s)	Summary
Pagination reset timing correction apps/meteor/client/views/admin/rooms/RoomsTable.tsx	Removes setCurrent(0) side effect from useMemo query builder (lines 42–46), updates the memoization dependency array to remove setCurrent (line 58), and adds a dedicated useEffect (lines 74–78) that properly resets pagination when searchText changes and updates the previous filter text tracker.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically identifies the main change: fixing a side effect in useMemo in RoomsTable component.
Linked Issues check	✅ Passed	The PR successfully implements all objectives from issue #40589: extracts the setCurrent(0) side effect from useMemo into a useEffect, ensures pure computation in useMemo, and updates dependencies accordingly.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to fixing the identified React rendering contract violation in RoomsTable.tsx with no extraneous modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[cubic-dev-ai]

1 issue found across 3 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".changeset/fix-ip-whitelist-trim.md">

<violation number="1" location=".changeset/fix-ip-whitelist-trim.md:5">
P2: Changeset describes unrelated IP whitelist fix instead of the PR's RoomsTable useMemo fix</violation>
</file>

<sub>Reply with feedback, questions, or to request a fix.

Re-trigger cubic</sub>

[cubic-dev-ai]

P2: Changeset describes unrelated IP whitelist fix instead of the PR's RoomsTable useMemo fix

Prompt for AI agents

Check if this issue is valid — if so, understand the root cause and fix it. At .changeset/fix-ip-whitelist-trim.md, line 5:

<comment>Changeset describes unrelated IP whitelist fix instead of the PR's RoomsTable useMemo fix</comment>

<file context>
@@ -0,0 +1,5 @@
+"@rocket.chat/meteor": patch
+---
+
+fix: trim whitespace from IP whitelist entries in failed-login protection
</file context>