fix: make date chip gliding work with new virtualized list system#40621
fix: make date chip gliding work with new virtualized list system#40621pranithakshayreddy-tech wants to merge 1 commit into
Conversation
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📜 Recent review details🧰 Additional context used📓 Path-based instructions (1)**/*.{ts,tsx,js}📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
Files:
🧠 Learnings (5)📚 Learning: 2026-02-10T16:32:42.586ZApplied to files:
📚 Learning: 2026-05-11T20:30:35.265ZApplied to files:
📚 Learning: 2026-02-26T19:25:44.063ZApplied to files:
📚 Learning: 2026-02-26T19:25:44.063ZApplied to files:
📚 Learning: 2026-05-06T12:21:44.083ZApplied to files:
🔇 Additional comments (1)
WalkthroughThe PR updates the ChangesDate Divider Visibility
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
### Proposed changes
The floating date chip "gliding" effect was broken after the migration to the new virtualized list system.
The old code used a CSS selector targeting data-time='YYYYMMDD' to hide the date divider behind the floating chip. However, the new system uses data-id with a Unix timestamp instead.
Updated the listStyle CSS selector in useDateScroll.ts to target data-id using new Date(bubbleDate.date).getTime() to match the correct divider element and restore the gliding behavior.
### Issue(s)
Related to the TODO comment at useDateScroll.ts#L148
### Steps to test or reproduce
Open any room with many messages
Scroll up quickly through the message list
Observe the floating date chip at the top
The date divider behind the chip should now be hidden (opacity: 0)
Previously the divider was visible behind the chip — now it is correctly hidden
### Further comments
The removed TODO comment confirms this was a known issue left for future fixing after the virtualized list migration. No new dependencies or breaking changes introduced.
Summary by CodeRabbit