Skip to content

regression: Password TOTP failing for meteor methods #40626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gabriellsh wants to merge 2 commits into
base: release-8.5.0
Choose a base branch
from
+3 −2
Open

regression: Password TOTP failing for meteor methods #40626

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af70d19
fix: Password sent unencrypted
gabriellsh May 20, 2026
75699c7
Merge branch 'release-8.5.0' into fix/passwordTotpSettings
gabriellsh May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions apps/meteor/client/lib/2fa/process2faReturn.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,12 +138,13 @@ export const invokeTwoFactorModal = async (
props: {
...props,
onConfirm: async (code: string, method: string): Promise<void> => {
const actualCode = method === 'password' ? SHA256(code) : code;
if (validateCode) {
await validateCode(code, method);
await validateCode(actualCode, method);
}
isResolved = true;
imperativeModal.close();
resolve(method === 'password' ? SHA256(code) : code);
resolve(actualCode);
},
onClose: (): void => {
if (isClosed) {
Expand Down
Loading