regression: no visual feedback on 2FA prompt

[nazabucciarelli]

Proposed changes (including videos or screenshots)

The bug consists of no visual feedback being given to the user when getting into the Device management page from settings and introducing a wrong TOTP code. In order to re-add the 'Invalid password' or 'Invalid two factor code' notices to the user when the code/password is wrong, we have to rollback the use of the invalidAttempt prop and pass it through the modal components.

Issue(s)

CORE-2210 [Regression] No visual feedback is provided when entering an incorrect TOTP code

Steps to test or reproduce

1- Setup a Rocket.Chat workspace with an EE.
2- Enable 2FA.
3- Go to Setting -> Device management. You will be prompted with a 2FA code.
4- Introduce a wrong code.

Expected: The dialog will show 'Invalid password' or 'Invalid two factor code' depending on the configured 2FA method.

Further comments

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: da49f85

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 61b935b1-4b8b-48ea-b1f8-0fd4be28207a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov]

Codecov Report

❌ Patch coverage is 53.84615% with 12 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-8.5.0@be11acd). Learn more about missing BASE report.

Additional details and impacted files

@@               Coverage Diff                @@
##             release-8.5.0   #40649   +/-   ##
================================================
  Coverage                 ?   69.63%           
================================================
  Files                    ?     3338           
  Lines                    ?   123259           
  Branches                 ?    21993           
================================================
  Hits                     ?    85829           
  Misses                   ?    34061           
  Partials                 ?     3369           

Flag	Coverage Δ
e2e	59.12% <53.84%> (?)
e2e-api	45.97% <ø> (?)
unit	70.47% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[ggazzo]

It would be very interesting to know the root cause. I changed some things in the two-factor and SDK, and it would be good to know what kinds of changes actually broke the problem.