fix: add TEST_MODE=true to OAuth ratelimiter's 'skip'#40650
Conversation
|
Looks like this PR is ready to merge! 🎉 |
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🧰 Additional context used📓 Path-based instructions (1)**/*.{ts,tsx,js}📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)
Files:
🧠 Learnings (3)📚 Learning: 2026-02-26T19:25:44.063ZApplied to files:
📚 Learning: 2026-02-26T19:25:44.063ZApplied to files:
📚 Learning: 2026-05-06T12:21:44.083ZApplied to files:
🔇 Additional comments (1)
WalkthroughThis PR updates the OAuth route rate limiter configuration to skip throttling during test mode. When the ChangesOAuth rate limiter test mode bypass
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release-8.5.0 #40650 +/- ##
=================================================
+ Coverage 69.64% 69.68% +0.03%
=================================================
Files 3338 3338
Lines 123232 123243 +11
Branches 21949 21979 +30
=================================================
+ Hits 85830 85880 +50
+ Misses 34046 34005 -41
- Partials 3356 3358 +2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Proposed changes (including videos or screenshots)
The OAuth ratelimiter introduced in the #39760 doesn't skip properly when running in the CI. This PR adds
TEST_MODE=trueto it.Issue(s)
https://rocketchat.atlassian.net/browse/SB-997
Steps to test or reproduce
Further comments
Summary by CodeRabbit