f-1221 Add JSON import functionality for exercise creation and validation

[morozov-av]

Screen.Recording.2026-06-23.at.14.44.49.mov

[Copilot]

Pull request overview

Adds a “paste/import question JSON” workflow to the Assignment Builder’s exercise creation/editing UI, including basic JSON parsing + per-exercise-type structural validation and accompanying unit tests.

Changes:

• Introduces parseQuestionJsonInput and validateQuestionJsonForType utilities for parsing and validating pasted question JSON.
• Adds an ImportQuestionJsonModal and wires it into CreateExercise for create-mode import and edit-mode view/replace.
• Adds Vitest coverage for the new utils, modal behavior, and CreateExercise integration points.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
bases/rsptx/assignment_server_api/assignment_builder/src/utils/importQuestionJson.ts	New parsing + type-based required-field validation for imported question JSON.
bases/rsptx/assignment_server_api/assignment_builder/src/utils/importQuestionJson.spec.ts	Unit tests covering parse failures/success and per-type validation behavior.
bases/rsptx/assignment_server_api/assignment_builder/src/components/routes/AssignmentBuilder/components/exercises/components/CreateExercise/CreateExercise.tsx	Adds import/view-replace JSON entry points and applies imported JSON into the exercise factory initial data.
bases/rsptx/assignment_server_api/assignment_builder/src/components/routes/AssignmentBuilder/components/exercises/components/CreateExercise/CreateExercise.spec.tsx	Updates tests for new UI buttons and import application behavior.
bases/rsptx/assignment_server_api/assignment_builder/src/components/routes/AssignmentBuilder/components/exercises/components/CreateExercise/components/ImportQuestionJsonModal.tsx	New modal UI for selecting a type (when unlocked), pasting JSON, showing errors, and applying validated data.
bases/rsptx/assignment_server_api/assignment_builder/src/components/routes/AssignmentBuilder/components/exercises/components/CreateExercise/components/ImportQuestionJsonModal.spec.tsx	Modal tests for required type selection, parse errors, validation errors, and apply behavior.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

[bnmnetp]

Code review — JSON import for exercise creation

Reviewed the diff (main...f-1221). The parse/validate utility (importQuestionJson.ts) and the modal are solid and well-tested. The issues are in the CreateExercise.tsx integration.

1. (High) Stale importedData leaks into the next created exercise — wrong question_type gets saved

effectiveInitialData = importedData ?? initialData (CreateExercise.tsx:114), but importedData is only cleared on resetForm (line 60). Neither handleTypeSelect (65–72) nor handleCancel (74–81) clears it, and the in-form Cancel returns to the type-selection view without unmounting CreateExercise (it calls setSelectedType(null), not the parent onCancel).

Repro: Paste JSON for mchoice → land in the factory → click Cancel → pick a different type (e.g. activecode). ExerciseFactory remounts seeded with the leftover importedData, which still carries question_type: "mchoice" (set at line 103) plus the old field values. useBaseExercise merges {...getDefaultFormData(), ...initialData}, so the new activecode form inherits question_type: "mchoice" and the stale statement, and saves a corrupted exercise.

Fix: clear importedData (and bump factoryKey) in handleTypeSelect when the user picks a type manually.

2. (Medium) "View / Replace JSON" shows stale JSON after a replace, and re-applying discards the replacement

currentJson is memoized on [isEdit, initialData] (83–96) and passed to the modal as initialJson (line 178). After a user replaces the JSON via import, importedData updates but the initialData prop does not, so currentJson keeps reflecting the original question. The modal resets its textarea to initialJson on open, so reopening "View / Replace JSON" shows the pre-import JSON. Clicking Apply then re-imports the original and silently throws away the replacement (in-form edits are never reflected either).

3. (Low) handleImportApply can throw on empty languageOptions

handleImportApply calls mergeQuestionJsonWithDefaults(languageOptions, data) (line 99) → getDefaultQuestionJson does languageOptions[0].value, which throws if languageOptions is an empty array (dataset store not yet populated). The import button newly exposes this fragility on an interactive click path. Pre-existing pattern (shared with EditView), but worth a guard at the source.

---

Minor / non-blocking: the "object" branch in matchesType (importQuestionJson.ts) is dead — no rule uses type "object". Validation is intentionally shallow (top-level presence + type only), which the tests document; malformed array elements (e.g. optionList: [1,2,3]) pass and rely on downstream components tolerating them.

🤖 Generated with Claude Code

[bnmnetp]

Update: all three findings fixed

• A prototype #1 (High) — stale importedData leak: handleTypeSelect now clears importedData and bumps factoryKey, so picking a type manually after an import starts from defaults (no leftover question_type/fields). Regression test added.
• Duplicate Email & Not Saving my Completed Assignments #2 (Medium) — stale "View / Replace JSON": currentJson is now derived from effectiveInitialData (importedData ?? initialData) instead of the original prop, so the modal reflects an in-session import/replace rather than the original exercise. Regression test added.
• Missing Work in Week 3 and 4 on Runestone System for Bay Path University AWC course: CSC101AZ3-Applied Computing #3 (Low) — empty languageOptions crash: getDefaultQuestionJson now uses languageOptions?.[0]?.value instead of languageOptions && languageOptions[0].value (the old guard let an empty array through). Fixed at the source, so EditView and the import path both benefit.

All affected suites green (159/159), with new regression tests confirmed to fail on the pre-fix code.

🤖 Generated with Claude Code