Skip to content

chore: enforce consistent curly brace usage in if statements#21725

Open
Platonn wants to merge 4 commits into
developfrom
feature/enforce-eslint-curly-rule
Open

chore: enforce consistent curly brace usage in if statements#21725
Platonn wants to merge 4 commits into
developfrom
feature/enforce-eslint-curly-rule

Conversation

@Platonn

@Platonn Platonn commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Previously we used this convention but we didn't have it enforced.

The inline if occurrences were likely a result of AI generated code.

@Platonn Platonn requested review from a team as code owners July 10, 2026 12:42
@github-actions github-actions Bot marked this pull request as draft July 10, 2026 12:42

@rmch91 rmch91 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Platonn Platonn marked this pull request as ready for review July 10, 2026 16:58
@cypress

cypress Bot commented Jul 10, 2026

Copy link
Copy Markdown

spartacus    Run #54009

Run Properties:  status check passed Passed #54009  •  git commit 78031ca9c4 ℹ️: Merge da8db264cbcbbf6004995292cec970737ea01643 into 80cecbac360a00ff497883cb28dc...
Project spartacus
Branch Review feature/enforce-eslint-curly-rule
Run status status check passed Passed #54009
Run duration 04m 51s
Commit git commit 78031ca9c4 ℹ️: Merge da8db264cbcbbf6004995292cec970737ea01643 into 80cecbac360a00ff497883cb28dc...
Committer Krzysztof Platis
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 3
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 103
View all changes introduced in this branch ↗︎

@github-actions github-actions Bot marked this pull request as draft July 10, 2026 17:34
@Platonn Platonn marked this pull request as ready for review July 10, 2026 17:35
@github-actions github-actions Bot marked this pull request as draft July 13, 2026 08:40
@Platonn Platonn marked this pull request as ready for review July 13, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants