VAD Fix: explicit safe context, reduced RAM usage#1406
Open
Purfview wants to merge 3 commits into
Open
Conversation
VAD Fix: explicit safe context (no view mutation). Reduced VAD RAM usage.
Collaborator
|
Hi, I get that this may modify the array in place, but I don't understand how that affects multiple model calls, do you mean consecutive calls on the same audio array or multiple calls in parallel for the same or different audios? |
Contributor
Author
As I remember it affected both consecutive and parallel calls with different size audios. Not sure now, I think it affected same size audios too but only(?) the last prob was affected. |
Contributor
Author
|
Analyzed probs from batched VAD [with 100% overlap] vs non-batched Pre patch stats: After the patch: Off-topic: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VAD Fix: explicit safe context (no view mutation).
Reduced SileroVADModel RAM usage by 9% [on 4h audio].
PR doesn't affect VAD speed nor probs output in current FW VAD functionality.
Fixes inconsistent outputs with multiple model calls [such functionality is currently not implemented].