Automated source and target restrictions of functor properties#218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A functor property such as being representable requires that the target category be Set. Previously, when non-representability could not be deduced (for example, in the case of a continuous functor), it was necessary to manually mark the functor as not representable, even when the target category was not Set. This has now been automated.
Specifically, in the file defining a functor property, one can add the optional fields
required_sourceandrequired_target. Inrepresentable.yaml, the following has been added:The deduction script now automatically marks this property as false for all functors whose target is not Set. More precisely, this is done before the main deduction procedure for functors starts, and the assignment is registered as "non-deduced" since it is too basic.