-
Notifications
You must be signed in to change notification settings - Fork 101
Jb/documentation updates #1635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jbrossman
wants to merge
49
commits into
main
Choose a base branch
from
jb/documentation-updates
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Jb/documentation updates #1635
Changes from all commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
bcba6ba
Additional changes to supplemental attributes and initial changes to …
828910d
Update figure size
db59c76
Add to glossary and fix spelling mistakes
6ee4e64
Additional spelling edits
5ae3d74
Changed accessor to getter functions
2e3b27b
Supplemental attribute changes
cede0fb
First pass at edits to system
386116e
Finish system explanation edits
0d81648
Ran compilation and fixed mostly reference issues
f921449
Edits to Type Structure Explanation
0224c49
Edits to buses_type_explanation.md
499baef
Edits to Power Concepts
d116d78
Edits to conforming and non-conforming loads
ce0fc4d
Address requested edits
a65d888
Transformer per unit transformations and per-unit conventions edits
73d451d
time_series edits
9e049ca
Dynamic devices edits
d8e579f
Tag out @id tags in tutorials
08f79af
Convert '''julia blocks to '''repl blocks
3d3f9a6
Implement best practices for hyperlinks
4449319
Concrete vs abstract supplemental attributes
ecd69fa
Add info about broadcast functions
6844b0f
Glossary edits for plant_attributes
4d13017
Add more getter functions
a344bbe
Docstring edits
08c2d07
More docstring edits
35e8fbd
More docstring edits
b228162
Even more docstring edits
ded0513
Address enum issues in #1611
d907136
Doc string edits to PowerSystems and compile
6c2ab2c
Compilation edits
jbrossman cfde49c
Merge branch 'main' into jb/documentation-updates
jbrossman ade8efe
Fixing issues from compilation
jbrossman 0dcd08b
Merge branch 'main' into jb/documentation-updates
jbrossman 907f72a
Suggested change from copilot to prevent failure
jbrossman 286452b
Remove line from transform_single_time_series
jbrossman 62cae42
Issues with previous build
jbrossman 6e722c0
Run tests locally and recompile
jbrossman a209d03
Merge branch 'main' into jb/documentation-updates
jbrossman df51ede
Initial changes, does not include docstring edits
jbrossman 60876fd
C level docstring effort
jbrossman 0fad077
Merging main into personal branch
jbrossman 5b521ae
Documentation corrections
jbrossman 31b8e66
Fixing compilation errors
jbrossman 8e3a718
Final compilation edits
jbrossman 6bf5838
Bring back a keyword argument
jbrossman 2ae0447
Merge branch 'main' into jb/documentation-updates
jbrossman e9ce9db
Delete requested files
jbrossman be6a930
Merge branch 'jb/documentation-updates' of https://github.com/Sienna-…
jbrossman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,7 @@ Pages = ["PowerSystems.jl", | |
| "injection.jl", | ||
| "devices.jl", | ||
| "loads.jl", | ||
| "supplemental_constructors", | ||
| "supplemental_constructors.jl", | ||
| "generation.jl", | ||
| "reserves.jl", | ||
| "storage.jl", | ||
|
|
@@ -20,7 +20,6 @@ Pages = ["PowerSystems.jl", | |
| "static_models.jl", | ||
| "subsystems.jl", | ||
| "static_injection_subsystem.jl", | ||
| "dynamic_models.jl", | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is this removed?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is listed twice. See line 19. |
||
| "operational_cost.jl", | ||
| "cost_function_timeseries.jl", | ||
| "definitions.jl" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs list the fuel enum value as
OTHER_BIOMASS_GAS, but the actual enum insrc/definitions.jlis spelledOTHEHR_BIOMASS_GAS. This mismatch will confuse users and example code will fail if they follow the docs. Either update the enum name in code (and provide a deprecation alias if needed) or keep the docs aligned with the current exported name.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update
src/definitions.jland any other uses and note the breaking change in PR commentThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kdayday