Improve logging and multi-processing. - #62
Open
jangroter wants to merge 2 commits into
Open
Conversation
…d bug in environment initialization
Collaborator
Author
|
TODO before merge:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current multi-processing script has two bugs:
Bug 1 and proposed solution
When initializing the seperate environment instances for the different CPUs each instance uses the same seed. This is solved by using Stable-Baselines3's own
SubprocVecEnvclass, which handles this naturally.Bug 2 and proposed solution
The current logger implementation only logs the first environment instance when using multi-processing, the proposed change loops through all the environments done flags and adds them to their own row when necessary. The new log-files contain an additional
env_idflag.Example to demonstrate logging functionality over multiple parallel instances: