Skip to content

feat(sidebar): navigate search results with arrow keys and open with Enter#1359

Open
shouwang0527 wants to merge 1 commit into
TableProApp:mainfrom
shouwang0527:feat/search-arrow-key-navigation
Open

feat(sidebar): navigate search results with arrow keys and open with Enter#1359
shouwang0527 wants to merge 1 commit into
TableProApp:mainfrom
shouwang0527:feat/search-arrow-key-navigation

Conversation

@shouwang0527
Copy link
Copy Markdown
Contributor

@shouwang0527 shouwang0527 commented May 20, 2026

Summary

  • Arrow keys (up/down) navigate through filtered table results while the sidebar search field is focused
  • Enter opens the currently selected table, matching DataGrip's search-then-navigate workflow

Fixes #1280

Implementation

  • Added control(_:textView:doCommandBy:) to SidebarContainerViewController to intercept arrow keys and Enter in the native NSSearchField
  • Arrow navigation updates sidebarState.selectedTables to move through the filtered list
  • Enter triggers the same open-table logic as double-click (including preview window routing)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 20, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@shouwang0527
Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA.

…Enter (TableProApp#1280)

Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
@shouwang0527 shouwang0527 force-pushed the feat/search-arrow-key-navigation branch from 9422aa2 to 4a8edba Compare May 20, 2026 13:14
@shouwang0527
Copy link
Copy Markdown
Contributor Author

recheck

@shouwang0527 shouwang0527 marked this pull request as draft May 20, 2026 13:36
@shouwang0527 shouwang0527 marked this pull request as ready for review May 20, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

搜索出来表之后,无法通过上下箭头直接选择然后回车

1 participant