🎨 Palette: Add accessibility attributes to icon-only close buttons#184
🎨 Palette: Add accessibility attributes to icon-only close buttons#184TargetMisser wants to merge 1 commit into
Conversation
Co-authored-by: TargetMisser <52361977+TargetMisser@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
Added
accessible={true},accessibilityRole="button",accessibilityLabel={t('close')}, and a generoushitSlopto icon-only close buttons (<TouchableOpacity>) inDrawerMenu,ProfileSwitcherModal, andShiftTimeline. Added the localized'close'string to the translation files (src/i18n/translations.ts).🎯 Why:
Icon-only buttons are invisible to screen readers without proper labeling. The added
hitSlopalso dramatically improves the touchable area of small icons on mobile devices, making them much easier to tap without increasing their visual footprint.📸 Before/After:
Visuals remain unchanged, but the touch target is larger and screen readers will now correctly announce "Button: Close" (or the localized equivalent).
♿ Accessibility:
accessibilityLabelusing thet('close')translation.accessibilityRole="button"andaccessible={true}.hitSlop={{ top: 8, bottom: 8, left: 8, right: 8 }}for better physical touch interaction.PR created automatically by Jules for task 8832660500638792910 started by @TargetMisser