feat(ci): before devnet deployment, pull and apply start script from Xinfin-Node to configmap#2361
feat(ci): before devnet deployment, pull and apply start script from Xinfin-Node to configmap#2361wanwiset25 wants to merge 2 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Revert "remove redundant start-scripts (use injection from Xinfin-Node repo)" This reverts commit 50aca80. remove redundant start-scripts (use injection from Xinfin-Node repo)
wanwiset25
force-pushed
the
ci-apply-start-script
branch
from
50aca80 to
e5445f2
Compare
| set -euo pipefail | ||
| curl -fsSL -o start-devnet.sh https://raw.githubusercontent.com/XinFinOrg/XinFin-Node/devnet/devnet/start-devnet.sh | ||
| curl -fsSL -o start-apothem.sh https://raw.githubusercontent.com/XinFinOrg/XinFin-Node/master/testnet/start-apothem.sh | ||
| curl -fsSL -o start-node.sh https://raw.githubusercontent.com/XinFinOrg/XinFin-Node/master/mainnet/start-node.sh |
There was a problem hiding this comment.
Do we need mainnet and testnet start script in k8s configmap?
4 participants
Proposed changes
Before devnet deployment, pull and apply start script from Xinfin-Node to configmap.
Remove redundant start-scripts inside XDPoSChain repo
Types of changes
What types of changes does your code introduce to XDC network?
Put an
✅in the boxes that applyImpacted Components
Which parts of the codebase does this PR touch?
Put an
✅in the boxes that applyChecklist
Put an
✅in the boxes once you have confirmed below actions (or provide reasons on not doing so) that