⚡️ clean up result.text()#150
Open
doron2402 wants to merge 1 commit into
Open
Conversation
Author
|
hey @a-tokyo let me know if there's anything I can add to this PR |
a-tokyo
requested changes
Dec 22, 2022
a-tokyo
left a comment
a-tokyo
left a comment
Owner
There was a problem hiding this comment.
Thanks a lot for your work!
Thanks for your patience, I haven't seen the notifs for this
| @@ -0,0 +1 @@ | |||
| v16.17.1 | |||
a-tokyo
changed the title
a-tokyo
changed the title
Owner
|
Sidenote: I believe this code was added to handle an edge case, I will trace back and check the reason for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
.json()instead of usingJSON.parse