Changes#2
Conversation
1. Most all Force Close's are gone. Small Functional Changes: 1. Put the service in charge of going to the next song. 2. Added a custom broadcast and receiver to handle song changes a. Using the asynctask caused references to become "stale" when configurations changed Minor cosmetic changes: 1. Increased album imageview size 2. Added a custom landscape layout 3. Increased Text size. Bugs: 1. If you log out while in the player, restart the app, and log back in there's a bug in the pandora api that I can't seem to track down that causes getStations in PandoraRadio.java to return null from a XMLRPCFaultException. Only a complete kill/FC of the app seems to fix it. 2. Probably others
album artwork for faster reloading when screen rotates, play button bug fix
|
First, THANK YOU for all the work! I have actually been working on my own re-factoring of the PandoraRadio class(es) with the eventual goal of improving stability. I've already pulled your repo into my local system to start merging it with my work. I haven't compiled/reviewed everything in this pull request yet, but it appears that you have done most of your work on the front end/android stuff (com.aregner.android.pandoid package) and i have been working mostly on the pandora radio library (com.aregner.pandora). I'll be finishing up my work soon, commit that, and then merge yours into it I think. It just may be a little while until I can get the time to resolve everything nicely. But thanks again, I'm really excited :-) |
|
But thanks again, I'm really excited :-) You and me both! I've been looking for a good project to get me back into On Sat, Oct 15, 2011 at 9:01 PM, Andrew Regner <
|
PandoraRadio.java turns into gibberish if you disconnect and reconnect. Making it non-static ensures this won't happen. This, I believe is the same fc that happens if the player has been paused for a long and attempts to reconnect.
list.Various bug fixes and improvements.
after your auth tokens change.
2 participants
Added high-res artwork using LastFM api, implemented image caching for
album artwork for faster reloading when screen rotates, play button bug
fix