Zoom window instead of resizing.#30
Open
cgull wants to merge 1 commit into
Open
Conversation
Owner
|
@cgull Will look at this shortly but just wanted to say you gave me a hearty laugh at picturing what the resize was doing on your dual monitors. Haha. Thanks for sharing that story :) |
Author
|
Oh yeah, I tested this on a script reduced to only the window actions. I couldn't test it with the real thing. I'm done Amazon shopping for now, soon I will have food for the next 3 weeks... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, thanks! I got the two delivery slots I needed with your script.
I've got a Retina iMac with a 1920x1080 second monitor (non-Retina) to the right. Given my particular configuration, the desktop on the second monitor is perhaps 60% as tall as the built-in display, I have to make windows shorter before moving them across.
When this script gets a slot, it unminimizes the window and resizes it to the desktop. Unfortunately, on my system, that creates a giant, almost unusable window that extends across both monitors to the full height of the Retina display. As I remember it, I clicked through to the confirm-order page, and the Amazon Buy button ended up hidden under my Notifications, and the zoom button was unhelpful since the window has actually been resized-- it just grows the window by a pixel or two to fill the entire screen. I had to resize the window. (But I still did get my slots.)
I'd like to suggest this change. On my system, the window vertically zooms to full height and its width grows a bit. The zoom button returns it to its previous size. And it's simpler code. I'm unclear on the full behavior of zoom, but I suspect it's intelligent enough to grow only to one display on multi-monitor systems.