Fix UI#60
Merged
Merged
Conversation
Member
Author
|
@npaulish best we discuss the changes over a (very) brief call. |
edan-bainglass
commented
May 8, 2026
| self.plot_wannier_functions = parameters.get('plot_wannier_functions', False) | ||
| self.number_of_disproj_max = parameters.get('number_of_disproj_max', 15) | ||
| self.number_of_disproj_min = parameters.get('number_of_disproj_min', 2) | ||
| self.compute_fermi_surface = parameters.get('compute_fermi_surface', False) |
edan-bainglass
commented
May 8, 2026
Member
Author
There was a problem hiding this comment.
Much of what is changed here is just about standardizing the structure of the settings panel w.r.t how we do things in the QE app.
edan-bainglass
commented
May 8, 2026
Comment on lines
+320
to
+323
| ipw.link( | ||
| (self._model, 'frozen_type'), | ||
| (self.frozen_type, 'value'), | ||
| ) |
Member
Author
There was a problem hiding this comment.
This was actually being assigned on a redundant frozen_type widget that was not being used.
edan-bainglass
commented
May 8, 2026
Comment on lines
-360
to
-368
| self.frozen_type = ipw.Dropdown( | ||
| options=['fixed_plus_projectability', 'projectability', 'energy_fixed'], | ||
| value=self._model.frozen_type, | ||
| description='Frozen states:', | ||
| style={'description_width': 'initial'}, | ||
| ) | ||
| ipw.link( | ||
| (self._model, 'frozen_type'), | ||
| (self.frozen_type, 'value'), |
edan-bainglass
commented
May 8, 2026
Comment on lines
+357
to
+363
| optimize_pdwf_info = ipw.HTML( | ||
| """<div class="alert alert-warning"> | ||
| <b>Note:</b> If <b>Optimize PDWF thresholds</b> is enabled, an | ||
| exhaustive scan of the PDWF thresholds is performed (up to 30 | ||
| Wannierizations) to find those that bring the bands distance (for | ||
| bands up to 2 eV above the Fermi level) below 10 meV. | ||
| </div>""" |
Member
Author
There was a problem hiding this comment.
This was a tooltip on the widget, but the tooltip parameter is not a thing for the Checkbox widget. Instead, it offers description_tooltip. However, this doesn't seem to work. For now, the tooltip is cast as a warning below the checkbox.
edan-bainglass
commented
May 8, 2026
| return | ||
|
|
||
| if self.compute_fermi_surface.value: | ||
| if self._model.compute_fermi_surface: |
Member
Author
There was a problem hiding this comment.
We should not rely on widget values, but rather on model values!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses two issues:
compute_fermi_surfacewasn't being set on process loadcompute_fermi_surfacewas deselectedThe PR address a few other bugs/inconsistencies noticed alonged the way.
Closes #57
Closes #59