Expose Map zone outputs to the client after wg.run()#777
Draft
GeigerJ2 wants to merge 4 commits into
Draft
Conversation
Zone/Map tasks have no AiiDA process node (`pk=None`), so `Task.update_state` could never populate their outputs on the client side. After `wg.run()`, `map_zone.outputs.<name>` returned an empty dict even though the engine had the correct gathered results internally. Three changes: - `gather()` now creates dynamic output namespaces so the client can assign per-prefix keys after the run. - `update_map_task_state` persists the gathered result node PKs in `task_map_info[name]['result_pks']` on the process node. - `WorkGraph.update()` reads those PKs back and populates the zone task's output sockets via `_populate_zone_outputs`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zone/Map tasks have no AiiDA process node (
pk=None), soTask.update_statecould never populate their outputs on the clientside. After
wg.run(),map_zone.outputs.<name>returned an empty dicteven though the engine had the correct gathered results internally.
Three changes:
gather()now creates dynamic output namespaces so the client canassign per-prefix keys after the run.
update_map_task_statepersists the gathered result node PKs intask_map_info[name]['result_pks']on the process node.WorkGraph.update()reads those PKs back and populates the zonetask's output sockets via
_populate_zone_outputs.