Skip to content

tests: Disable JoinConfigCompatCheckerSpec and HandshakeRetrySpec on aeron #32903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johanandren wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −17
Open

tests: Disable JoinConfigCompatCheckerSpec and HandshakeRetrySpec on aeron #32903

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 20 additions & 16 deletions akka-cluster/src/test/scala/akka/cluster/JoinConfigCompatCheckerSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import scala.concurrent.duration._

import com.typesafe.config.{ Config, ConfigFactory }

import akka.testkit.{ AkkaSpec, LongRunningTest }
import akka.testkit.{ AkkaSpec, GHExcludeAeronTest, LongRunningTest }

object JoinConfigCompatCheckerSpec {

Expand Down Expand Up @@ -47,9 +47,13 @@ object JoinConfigCompatCheckerSpec {
class JoinConfigCompatCheckerSpec extends AkkaSpec with ClusterTestKit {
import JoinConfigCompatCheckerSpec._

// All tests are long-running and excluded from aeron transport CI runs
override def tags: Map[String, Set[String]] =
testNames.map(_ -> Set(LongRunningTest.name, GHExcludeAeronTest.name)).toMap

"A Joining Node" must {

"be allowed to join a cluster when its configuration is compatible" taggedAs LongRunningTest in {
"be allowed to join a cluster when its configuration is compatible" in {

val clusterTestUtil = new ClusterTestUtil(system.name)
// first node
Expand All @@ -65,7 +69,7 @@ class JoinConfigCompatCheckerSpec extends AkkaSpec with ClusterTestKit {

}

"NOT be allowed to join a cluster when its configuration is incompatible" taggedAs LongRunningTest in {
"NOT be allowed to join a cluster when its configuration is incompatible" in {
// this config is NOT compatible with the cluster config
val joinNodeConfig =
ConfigFactory.parseString("""
Expand Down Expand Up @@ -102,7 +106,7 @@ class JoinConfigCompatCheckerSpec extends AkkaSpec with ClusterTestKit {

}

"NOT be allowed to join a cluster when one of its required properties are not available on cluster side" taggedAs LongRunningTest in {
"NOT be allowed to join a cluster when one of its required properties are not available on cluster side" in {

// this config is NOT compatible with the cluster config
// because there is one missing required configuration property.
Expand Down Expand Up @@ -143,7 +147,7 @@ class JoinConfigCompatCheckerSpec extends AkkaSpec with ClusterTestKit {

}

"NOT be allowed to join a cluster when one of the cluster required properties are not available on the joining side" taggedAs LongRunningTest in {
"NOT be allowed to join a cluster when one of the cluster required properties are not available on the joining side" in {

// this config is NOT compatible with the cluster config
// because there is one missing required configuration property.
Expand Down Expand Up @@ -180,7 +184,7 @@ class JoinConfigCompatCheckerSpec extends AkkaSpec with ClusterTestKit {

}

"be allowed to join a cluster when one of its required properties are not available on cluster side but it's configured to NOT enforce it" taggedAs LongRunningTest in {
"be allowed to join a cluster when one of its required properties are not available on cluster side but it's configured to NOT enforce it" in {

// this config is NOT compatible with the cluster config
// because there is one missing required configuration property.
Expand Down Expand Up @@ -218,7 +222,7 @@ class JoinConfigCompatCheckerSpec extends AkkaSpec with ClusterTestKit {

}

"be allowed to join a cluster when its configuration is incompatible but it's configured to NOT enforce it" taggedAs LongRunningTest in {
"be allowed to join a cluster when its configuration is incompatible but it's configured to NOT enforce it" in {
// this config is NOT compatible with the cluster config,
// but node will ignore the the config check and join anyway
val joinNodeConfig =
Expand Down Expand Up @@ -253,7 +257,7 @@ class JoinConfigCompatCheckerSpec extends AkkaSpec with ClusterTestKit {
}

/** This test verifies the built-in JoinConfigCompatCheckerAkkaCluster */
"NOT be allowed to join a cluster using a different value for akka.cluster.downing-provider-class" taggedAs LongRunningTest in {
"NOT be allowed to join a cluster using a different value for akka.cluster.downing-provider-class" in {

val joinNodeConfig =
ConfigFactory.parseString("""
Expand Down Expand Up @@ -292,7 +296,7 @@ class JoinConfigCompatCheckerSpec extends AkkaSpec with ClusterTestKit {

"A First Node" must {

"be allowed to re-join a cluster when its configuration is compatible" taggedAs LongRunningTest in {
"be allowed to re-join a cluster when its configuration is compatible" in {

val clusterTestUtil = new ClusterTestUtil(system.name)
// first node
Expand All @@ -319,7 +323,7 @@ class JoinConfigCompatCheckerSpec extends AkkaSpec with ClusterTestKit {

}

"NOT be allowed to re-join a cluster when its configuration is incompatible" taggedAs LongRunningTest in {
"NOT be allowed to re-join a cluster when its configuration is incompatible" in {
// this config is NOT compatible with the cluster config
val joinNodeConfig =
ConfigFactory.parseString("""
Expand Down Expand Up @@ -362,7 +366,7 @@ class JoinConfigCompatCheckerSpec extends AkkaSpec with ClusterTestKit {

}

"NOT be allowed to re-join a cluster when one of its required properties are not available on cluster side" taggedAs LongRunningTest in {
"NOT be allowed to re-join a cluster when one of its required properties are not available on cluster side" in {

// this config is NOT compatible with the cluster config
// because there is one missing required configuration property.
Expand Down Expand Up @@ -410,7 +414,7 @@ class JoinConfigCompatCheckerSpec extends AkkaSpec with ClusterTestKit {

}

"NOT be allowed to re-join a cluster when one of the cluster required properties are not available on the joining side" taggedAs LongRunningTest in {
"NOT be allowed to re-join a cluster when one of the cluster required properties are not available on the joining side" in {

// this config is NOT compatible with the cluster config
// because there is one missing required configuration property.
Expand Down Expand Up @@ -454,7 +458,7 @@ class JoinConfigCompatCheckerSpec extends AkkaSpec with ClusterTestKit {

}

"be allowed to re-join a cluster when one of its required properties are not available on cluster side but it's configured to NOT enforce it" taggedAs LongRunningTest in {
"be allowed to re-join a cluster when one of its required properties are not available on cluster side but it's configured to NOT enforce it" in {

// this config is NOT compatible with the cluster config
// because there is one missing required configuration property.
Expand Down Expand Up @@ -502,7 +506,7 @@ class JoinConfigCompatCheckerSpec extends AkkaSpec with ClusterTestKit {

}

"be allowed to re-join a cluster when its configuration is incompatible but it's configured to NOT enforce it" taggedAs LongRunningTest in {
"be allowed to re-join a cluster when its configuration is incompatible but it's configured to NOT enforce it" in {
// this config is NOT compatible with the cluster config,
// but node will ignore the the config check and join anyway
val joinNodeConfig =
Expand Down Expand Up @@ -549,7 +553,7 @@ class JoinConfigCompatCheckerSpec extends AkkaSpec with ClusterTestKit {
}

"A Cluster" must {
"NOT exchange sensitive config paths with joining node" taggedAs LongRunningTest in {
"NOT exchange sensitive config paths with joining node" in {

// this config has sensitive properties that are not compatible with the cluster
// the cluster will ignore them, because they are on the sensitive-config-path
Expand Down Expand Up @@ -599,7 +603,7 @@ class JoinConfigCompatCheckerSpec extends AkkaSpec with ClusterTestKit {
}
}

"be allowed to disable a check" taggedAs LongRunningTest in {
"be allowed to disable a check" in {

// this config has sensitive properties that are not compatible with the cluster
// the cluster will ignore them, because they are on the sensitive-config-path
Expand Down
3 changes: 2 additions & 1 deletion akka-remote/src/test/scala/akka/remote/artery/HandshakeRetrySpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import scala.concurrent.duration._
import com.typesafe.config.ConfigFactory

import akka.actor._
import akka.testkit.GHExcludeAeronTest
import akka.testkit.ImplicitSender
import akka.testkit.TestActors

Expand All @@ -26,7 +27,7 @@ class HandshakeRetrySpec extends ArteryMultiNodeSpec(HandshakeRetrySpec.commonCo

"Artery handshake" must {

"be retried during handshake-timeout (no message loss)" in {
"be retried during handshake-timeout (no message loss)" taggedAs (GHExcludeAeronTest) in {
def sel = system.actorSelection(s"akka://systemB@localhost:$portB/user/echo")
sel ! "hello"
expectNoMessage(1.second)
Expand Down
Loading