fix: pass S3/S4 params for all AWG containers, not only Awg2#2648
Open
artmchk-pixel wants to merge 1 commit into
Open
fix: pass S3/S4 params for all AWG containers, not only Awg2#2648artmchk-pixel wants to merge 1 commit into
artmchk-pixel wants to merge 1 commit into
Conversation
cookieReplyPacketJunkSize and transportPacketJunkSize (S3/S4) were only set when container == DockerContainer::Awg2. This caused AWG 2.0 to not work for third-party imported configs (vpn:// links) on Linux and other platforms since those use DockerContainer::Awg. Fixes: transport data blocked with AWG 2.0 servers (issue amnezia-vpn#2219)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
cookieReplyPacketJunkSize and transportPacketJunkSize (S3/S4) were only
set when container == DockerContainer::Awg2. This caused AWG 2.0 to not
work for third-party imported configs (vpn:// links) on Linux because
those use DockerContainer::Awg.
Root cause
In awgConfigurator.cpp, S3/S4 were wrapped in:
if (container == DockerContainer::Awg2) { ... }
Fix
Remove the condition so S3/S4 are always passed regardless of container type.
Fixes #2219