Skip to content

fix: break SDK iterator after result message to prevent hang in pull_request runs #1339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scobbe wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −0
Open

fix: break SDK iterator after result message to prevent hang in pull_request runs #1339

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions base-action/src/run-claude-sdk.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,16 @@ export async function runClaudeWithSdk(

if (message.type === "result") {
resultMessage = message as SDKResultMessage;
// The SDK's query() iterator should close itself after the
// result message, but in some workflow contexts (notably
// pull_request-triggered runs) it stays open indefinitely and
// the for-await hangs until the workflow's timeout-minutes
// kills the job. This causes the action to "succeed" inside
// Claude (verdict posted, $cost recorded) but be reported as
// cancelled with no execution-output.json written. Break
// explicitly: by SDK contract no further messages follow a
// result, so the break is safe.
break;
}
}
} catch (error) {
Expand Down