Add suppressed exception details in NativeFSLockFactory lock acquisit…

[Bharathi-Kanna]

Follow-up to #16278. Resolves the // TODO: addSuppressed in NativeFSLockFactory.tryLock.

Now that the concerns are separated, this replaces the silent swallowing of channel close exceptions on lock failure with IOUtils.closeWhileSuppressingExceptions, attaching any close failure as a suppressed exception.

Changes

• NativeFSLockFactory.java: Swapped finally/closeWhileHandlingException for catch (Throwable t)/closeWhileSuppressingExceptions in tryLock.
• TestNativeFSLockFactory.java: Added testSuppressedExceptionOnLockFailure using a mock filesystem to verify the suppressed exception behavior.
• CHANGES.txt: Added release log entry.

[Bharathi-Kanna]

Hi @rmuir, this is the follow-up PR to #16278 that resolves the remaining TODO: addSuppressed in tryLock. I'd appreciate your review when you have a chance!

[uschindler]

I think this new code is fine. Goes in line with other code in Lucene, e.g.,:

lucene/lucene/codecs/src/java/org/apache/lucene/codecs/blocktreeords/BlockTreeOrdsPostingsFormat.java

Lines 72 to 78 in 401c655

	try {
	return new OrdsBlockTreeTermsWriter(
	state, postingsWriter, minTermBlockSize, maxTermBlockSize);
	} catch (Throwable t) {
	IOUtils.closeWhileSuppressingExceptions(t, postingsWriter);
	throw t;
	}

The used method ('closeWhileHandlingExceptions()') here was written for that use-case.

[uschindler]

Move this variable inside try block, it is no longer needed outside.