Configure TLS resources for bind canonical tests#3210
Merged
Conversation
Motivation: PR validation failed in BindCanonicalAddressSpec when tls-tcp used the reference.conf default keystore path. Modification: Reuse the existing ArterySpecSupport TLS test configuration for the bind canonical address spec so tls-tcp tests resolve the test keystore and truststore resources. Result: The TLS bind canonical address cases no longer fail with NoSuchFileException: keystore. Tests: - rtk bash -lc 'export JAVA_HOME=/Users/hepin/Library/Java/JavaVirtualMachines/azul-17.0.17/Contents/Home; export PATH="/Users/hepin/.sdkman/candidates/java/current/bin:/Users/hepin/.nvm/versions/node/v22.23.0/lib/node_modules/@openai/codex/node_modules/@openai/codex-darwin-arm64/vendor/aarch64-apple-darwin/codex-path:/Users/hepin/.nvm/versions/node/v22.23.0/lib/node_modules/@openai/codex/node_modules/@openai/codex-darwin-arm64/vendor/aarch64-apple-darwin/codex-path:/Users/hepin/.codex/tmp/arg0/codex-arg02IyHp2:/Applications/Wukong.app/Contents/Resources/resources/dingsync/realdoc.app/Contents/MacOS:/Users/hepin/.local/bin:/Users/hepin/.nvm/versions/node/v22.23.0/bin:/Users/hepin/.mimocode/bin:/Users/hepin/Library/Python/3.10/bin:/Users/hepin/.qoderwork/bin:/Users/hepin/.opencode/bin:/Users/hepin/.antigravity/antigravity/bin:/Users/hepin/bin:/Users/hepin/.sdkman/candidates/java/current/bin:/Users/hepin/Library/Java/JavaVirtualMachines/openjdk-25.0.2/Contents/Home/bin:/Applications/Wukong.app/Contents/Resources/resources/dingsync/realdoc.app/Contents/MacOS:/Users/hepin/.local/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/opt/pmk/env/global/bin:/Library/Apple/usr/bin:/Applications/Wireshark.app/Contents/MacOS:/Users/hepin/.tmo/bin:/Users/hepin/.local/bin:/Users/hepin/.cargo/bin:/Users/hepin/Library/Application Support/JetBrains/Toolbox/scripts:/Users/hepin/Library/Application Support/Coursier/bin:/Users/hepin/.local/bin"; java -version; sbt "remote / Test / testOnly org.apache.pekko.remote.artery.BindCanonicalAddressSpec"' / passed (15 tests) - rtk scalafmt --mode diff-ref=origin/main --non-interactive / passed - rtk scalafmt --list --mode diff-ref=origin/main --non-interactive / passed - rtk bash -lc 'git diff --check' / passed References: Refs apache#3205
pjfanning
approved these changes
Jun 27, 2026
pjfanning
left a comment
pjfanning
left a comment
Member
There was a problem hiding this comment.
lgtm
I saw this issue with the keystore not being found in a test run today - is this new or a longstanding intermittent issue?
Member
Author
|
The last change is 10 years ago at this line |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PR validation for #3205 exposed that
BindCanonicalAddressSpecfails thetls-tcpbind canonical address cases because the spec falls back to thereference.confdefaultkeystoreandtruststorerelative paths.Modification
Reuse the existing
ArterySpecSupport.tlsConfiginBindCanonicalAddressSpec.commonConfigso TLS transport cases resolve the test keystore and truststore resources.Result
The TLS bind canonical address cases no longer fail with
NoSuchFileException: keystore.Tests
rtk bash -lc "export JAVA_HOME=$(/usr/libexec/java_home -v 17); export PATH=\"$JAVA_HOME/bin:$PATH\"; java -version; sbt \"remote / Test / testOnly org.apache.pekko.remote.artery.BindCanonicalAddressSpec\""/ passed (15 tests)rtk scalafmt --mode diff-ref=origin/main --non-interactive/ passedrtk scalafmt --list --mode diff-ref=origin/main --non-interactive/ passedrtk bash -lc "git diff --check"/ passedReferences
Refs #3205