Fix Flaky .Net and server tests#3431
Open
Cole-Greer wants to merge 2 commits into
Open
Conversation
shouldTrackTransactionCountAccurately was racing because commitTx() and rollbackTx() returned without consuming the HTTP response. With chunked transfer encoding, the client can receive response headers before the server completes transactionManager.destroy(). Wrapping in try-with-resources ensures the full response is read, guaranteeing server-side processing is complete before asserting the count. shouldTimeoutIdleTransactionWithNoOperations used a 1ms timeout, which could expire during the beginTx() HTTP round-trip itself, causing getFirstHeader(TRANSACTION_ID) to return null and NPE. Increased to 500ms — still well below the 1000ms sleep that validates timeout behavior.
PropertyDeserializationTests and GraphTraversalTests were running concurrently with @GraphComputerOnly Gherkin scenarios. During OLAP computation, TinkerGraphComputer sets a graphComputerView on the shared TinkerGraph instance. Any concurrent read through TinkerVertex sees compute properties (like haltedTraversers) merged with real properties, causing spurious assertion failures and NPEs. Place all tests that hit the shared server into a single non-parallel xUnit collection (GremlinServerTests) so they never overlap with an active GraphComputer view.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
shouldTrackTransactionCountAccuratelywas racing because commitTx()and rollbackTx() returned without consuming the HTTP response. With
chunked transfer encoding, the client can receive response headers
before the server completes transactionManager.destroy(). Wrapping
in try-with-resources ensures the full response is read, guaranteeing
server-side processing is complete before asserting the count.
shouldTimeoutIdleTransactionWithNoOperationsused a 1ms timeout,which could expire during the beginTx() HTTP round-trip itself,
causing getFirstHeader(TRANSACTION_ID) to return null and NPE.
Increased to 500ms — still well below the 1000ms sleep that
validates timeout behavior.
PropertyDeserializationTestsandGraphTraversalTestswere runningconcurrently with
@GraphComputerOnlyGherkin scenarios. During OLAPcomputation, TinkerGraphComputer sets a graphComputerView on the
shared TinkerGraph instance. Any concurrent read through TinkerVertex
sees compute properties (like haltedTraversers) merged with real
properties, causing spurious assertion failures and NPEs.
Place all tests that hit the shared server into a single non-parallel
xUnit collection (GremlinServerTests) so they never overlap with an
active GraphComputer view.
VOTE +1