ListGuesser's custom empty element not shown when no filters and no data#672
Open
PawelSuwinski wants to merge 7 commits into
Open
ListGuesser's custom empty element not shown when no filters and no data#672PawelSuwinski wants to merge 7 commits into
PawelSuwinski wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A custom empty state element passed to ListGuesser is ignored in the common “no filters, no results” case. ListGuesser forwards the empty prop only to Datagrid, not to List, and the Datagrid (and its empty prop) is never mounted in such case. It only appears when filters are applied, because then List keeps the list layout and Datagrid handles the empty state.
So to fix it there is a need to forward also a List's empty prop and for example set it to
falseor just using empty only on the List level.