feat: Google OAuth prompt parameter and login OAuth error display#3056
Conversation
- Add dedicated googleOAuth.svelte modal with prompt picker in Advanced section - Add googlePromptPicker.svelte: tag-based multi-select enforcing none exclusivity - Wire prompt array through updateOAuth.ts to updateOAuth2Google SDK call - Fix OIDC advanced param detection to URL-based logic (all URL params except wellKnownURL) - Show OAuth failure URL error message on login page via onMount
Greptile SummaryThis PR introduces a dedicated Google OAuth2 settings modal with a tag-based prompt picker (
Confidence Score: 5/5The change is well-scoped: the new Google component mirrors patterns from mainOAuth.svelte, the prompt array wiring is isolated to the Google SDK call, and the login page notification uses a hardcoded string rather than reflecting URL content. All changed paths are additive or narrowly scoped. The prompt picker logic is straightforward, the updateOAuth.ts threading is non-breaking for all other providers, and the login page fix avoids user-controlled content in the notification. No defects were found that would affect data integrity or user-facing correctness. googlePromptPicker.svelte uses Svelte 5 runes syntax while the rest of the provider files use Svelte 4 — worth aligning before the codebase fully migrates. Important Files Changed
Reviews (2): Last reviewed commit: "format" | Re-trigger Greptile |
What does this PR do?
(Provide a description of what this PR does.)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)