Skip to content

Fix unobfuscated Forge builds (wrong mcp step, missing manifest)#349

Merged
Juuxel merged 5 commits into
architectury:dev/1.17from
addavriance:fix/forge-mcpconfig-patch-step-name
Jun 22, 2026
Merged

Fix unobfuscated Forge builds (wrong mcp step, missing manifest)#349
Juuxel merged 5 commits into
architectury:dev/1.17from
addavriance:fix/forge-mcpconfig-patch-step-name

Conversation

@addavriance

Copy link
Copy Markdown

finished up the unobfuscated Forge path a bit further (still rough since 9e04ddb)

  • createUnobfuscatedPrePatchJar() now also enqueues "merge" for Forge (preProcessJar alone resolved to 0 MCP steps there).
  • mergeUnobfuscatedPatchedJar() now writes an empty manifest instead of leaving it missing
  • Added Forge261Test/Forge262Test since there were 0 tests for unobfuscated Forge

@Juuxel Juuxel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally good, just one small note.

Comment thread src/main/java/dev/architectury/loom/forge/minecraft/MinecraftPatchedProvider.java Outdated
@addavriance addavriance requested a review from Juuxel June 22, 2026 14:35
@Juuxel Juuxel merged commit 2d7d5b6 into architectury:dev/1.17 Jun 22, 2026
65 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants