Skip to content

fix(UI): Updating repo secrets through CLI will update UI#27898

Open
adityaraj178 wants to merge 1 commit into
argoproj:masterfrom
adityaraj178:ui-repository-helm
Open

fix(UI): Updating repo secrets through CLI will update UI#27898
adityaraj178 wants to merge 1 commit into
argoproj:masterfrom
adityaraj178:ui-repository-helm

Conversation

@adityaraj178
Copy link
Copy Markdown
Contributor

Closes: #27859

Issues Fixed in the PR:

  1. Make repositories of type helm/OCI and credential templates updatable through UI
  2. When user update the secrets using CLI, Update the ui with latest connection status when user click Refresh List in ui

After fix:
https://github.com/user-attachments/assets/22661d8d-a0b0-412e-b832-5a3ab604f4ad

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: Aditya Raj <adityaraj10600@gmail.com>
@adityaraj178 adityaraj178 requested a review from a team as a code owner May 18, 2026 06:18
@bunnyshell
Copy link
Copy Markdown

bunnyshell Bot commented May 18, 2026

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@adityaraj178 adityaraj178 changed the title fix(UI)": Updating repo secrets through CLI will update UI fix(UI): Updating repo secrets through CLI will update UI May 18, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.23%. Comparing base (4fc98c0) to head (eeb722d).
⚠️ Report is 73 commits behind head on master.

Files with missing lines Patch % Lines
server/repository/repository.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #27898      +/-   ##
==========================================
+ Coverage   63.83%   64.23%   +0.40%     
==========================================
  Files         418      422       +4     
  Lines       57269    57851     +582     
==========================================
+ Hits        36558    37163     +605     
+ Misses      17295    17183     -112     
- Partials     3416     3505      +89     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Updating repo creds through CLI doesn't update UI

1 participant