Skip to content

feat: support RespectIgnoreDifferences sync per resource#27909

Open
shmargum wants to merge 1 commit into
argoproj:masterfrom
shmargum:feat/respect-ignore-differences-per-resource
Open

feat: support RespectIgnoreDifferences sync per resource#27909
shmargum wants to merge 1 commit into
argoproj:masterfrom
shmargum:feat/respect-ignore-differences-per-resource

Conversation

@shmargum
Copy link
Copy Markdown

@shmargum shmargum commented May 18, 2026

Resolves #13454

Allow resources to set RespectIgnoreDifferences behavior via the argocd.argoproj.io/sync-options annotation. This is useful when some resources in an app need to respect ignoreDifferences during sync while others do not.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

…urce level (argoproj#13454)

Allow resources to opt in to RespectIgnoreDifferences behavior via the
argocd.argoproj.io/sync-options annotation, without requiring the option
to be enabled for the entire application. This is useful when some resources
in an app need to respect ignoreDifferences during sync while others do not.

Signed-off-by: Maxim Ivanov <mivanov@paxos.com>
@shmargum shmargum requested review from a team as code owners May 18, 2026 22:19
@bunnyshell
Copy link
Copy Markdown

bunnyshell Bot commented May 18, 2026

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@26621ad). Learn more about missing BASE report.
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
controller/sync.go 75.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #27909   +/-   ##
=========================================
  Coverage          ?   64.24%           
=========================================
  Files             ?      422           
  Lines             ?    57828           
  Branches          ?        0           
=========================================
  Hits              ?    37154           
  Misses            ?    17173           
  Partials          ?     3501           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support RespectIgnoreDifferences sync option at individual resource level

1 participant