feat(appset): add Refresh RPC and UI action (#27798) by AsifAd · Pull Request #27932 · argoproj/argo-cd

AsifAd · 2026-05-19T19:05:08Z

Summary

Adds Refresh RPC on ApplicationSet service (POST /api/v1/applicationsets/{name}/refresh)
Server patches argocd.argoproj.io/application-set-refresh: "true" (controller already handles this)
UI Refresh action on AppSet list tile, table row, detail action menu, and resource details panel
Supports appsetNamespace for namespaced ApplicationSets

Test plan

go test ./server/applicationset/... — includes TestRefreshAppSet (default ns, named ns, forbidden ns, not found)
cd ui && pnpm test — 165 tests pass (incl. ApplicationSet refresh helpers)
ESLint on changed UI files
Manual: Kind + make start-local → Git-directory AppSet → Refresh from UI → verify annotation + reconcile (maintainer QA)

Expose ApplicationSet refresh via POST /api/v1/applicationsets/{name}/refresh which patches argocd.argoproj.io/application-set-refresh. Adds Refresh actions to AppSet list tile, table row, detail toolbar, and resource panel. Signed-off-by: Asif Draxi <asifdraxi@gmail.com>

bunnyshell · 2026-05-19T19:05:14Z

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

🔵 /bns:start to start the environment
🚀 /bns:deploy to redeploy the environment
❌ /bns:delete to remove the environment

Pass refreshApplicationSet through ApplicationTiles and ApplicationsTable so TypeScript lint passes when AppSets appear on /applications. Signed-off-by: Asif Draxi <asifdraxi@gmail.com>

Empty commit to re-run flaky race unit test job. Signed-off-by: Asif Draxi <asifdraxi@gmail.com>

codecov · 2026-05-19T20:48:47Z

Codecov Report

❌ Patch coverage is 86.66667% with 4 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@b035a77). Learn more about missing BASE report.
⚠️ Report is 17 commits behind head on master.

Files with missing lines	Patch %	Lines
server/applicationset/applicationset.go	86.66%	2 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##             master   #27932   +/-   ##
=========================================
  Coverage          ?   64.40%           
=========================================
  Files             ?      422           
  Lines             ?    57859           
  Branches          ?        0           
=========================================
  Hits              ?    37262           
  Misses            ?    17093           
  Partials          ?     3504

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nitishfy

can you share the screenshot of the UI?

AsifAd · 2026-05-20T07:30:05Z

/bns:deploy

AsifAd · 2026-05-20T08:02:51Z

Thanks for the review @nitishfy — UI screenshots from local testing on this branch (v3.5.0+fc514e8):

ApplicationSets list — tiles view (Refresh on tile)

ApplicationSets list — table view (Refresh action)

ApplicationSet details — toolbar Refresh

ApplicationSet details — action menu (Refresh visible in toolbar)

Refresh triggers POST /api/v1/applicationsets/{name}/refresh, which sets argocd.argoproj.io/application-set-refresh: "true" and the ApplicationSet controller reconciles.

ppapapetrou76

Can you please add a test for the retry mechanism and the waitSync after refresh?

Add conflict-retry, exhausted-retry, waitSync, and post-refresh waitSync tests requested in argoproj#27932 review feedback.

AsifAd · 2026-05-21T13:57:14Z

Addressed review feedback in 5629819:

Tests added (server/applicationset/applicationset_test.go):

TestRefreshAppSetWithConflicts — retry loop succeeds after an update conflict
TestRefreshAppSetTooManyConflicts — returns error after 10 conflicts
TestWaitSync — cache-up-to-date returns immediately; stale cache waits until timeout
TestRefreshAppSetWaitSync — refreshAppSet calls waitSync after a successful update

All new tests pass locally (go test ./server/applicationset/ -run 'TestRefreshAppSetWithConflicts|TestRefreshAppSetTooManyConflicts|TestWaitSync|TestRefreshAppSetWaitSync').

Re @ppapapetrou76's backoff suggestion on the retry loop — kept the existing fixed-interval retry for now since it matches the Application refresh pattern; happy to revisit if you'd prefer exponential backoff.

Add conflict-retry, exhausted-retry, waitSync, and post-refresh waitSync tests requested in argoproj#27932 review feedback. Signed-off-by: Asif Draxi <asifdraxi@gmail.com>

Align server refreshAppSet with webhook.refreshApplicationSet by using retry.RetryOnConflict(retry.DefaultBackoff) instead of a tight 10-attempt loop. Adjust exhausted-retry test for the new error shape. Signed-off-by: Asif Draxi <asifdraxi@gmail.com>

AsifAd · 2026-05-21T14:10:22Z

Follow-up in 22b937f2a / 78836acab:

Backoff (review feedback): refreshAppSet now uses retry.RetryOnConflict(retry.DefaultBackoff, ...), matching applicationset/webhook.refreshApplicationSet for the same refresh annotation patch.

DCO: Added missing Signed-off-by on the test commit (78836acab).

Tests pass locally for the refresh/waitSync suite.

AsifAd · 2026-05-22T08:52:40Z

Follow-up on review feedback — all addressed and the open thread is resolved:

Backoff: refreshAppSet now uses retry.RetryOnConflict(retry.DefaultBackoff, ...) (22b937f), aligned with the webhook refresh path.
Tests: conflict retry loop, too-many-conflicts error, and waitSync coverage (78836ac).
CI: full matrix green on latest SHA.

@ppapapetrou76 @nitishfy — ready for another look when you have a moment. Thanks!

ppapapetrou76

I'm not a UI expert so this PR needs a review from someone more familiar than I am

ppapapetrou76 · 2026-05-22T11:14:23Z

+func (s *Server) Refresh(ctx context.Context, q *applicationset.ApplicationSetGetQuery) (*v1alpha1.ApplicationSet, error) {
+	namespace := s.appsetNamespaceOrDefault(q.AppsetNamespace)
+
+	appset, err := s.getAppSetEnforceRBAC(ctx, rbac.ActionUpdate, namespace, q.Name)


The analogous Application hard-refresh uses rbac.ActionGet. Using ActionUpdate for a refresh-only action means read-only users or operators with get/sync privileges but not update will be blocked from triggering a refresh — which seems unintentional.

pjiang-dev · 2026-05-22T21:11:35Z

+	return updated, nil
+}
+
+func (s *Server) refreshAppSet(ctx context.Context, appset *v1alpha1.ApplicationSet) (*v1alpha1.ApplicationSet, error) {


i believe there is already a refreshApplicationSet() inside webhook.go that uses RetryOnConflict as well
Could we re-use that one instead of re-implementing it here?

Maybe we can extract a shared helper method for each caller

AsifAd requested a review from a team as a code owner May 19, 2026 19:05

AsifAd mentioned this pull request May 19, 2026

Add Refresh button for ApplicationSets #27798

Open

AsifAd added 2 commits May 20, 2026 00:40

fix(ui): wire AppSet Refresh in mixed applications list views

f57aa56

Pass refreshApplicationSet through ApplicationTiles and ApplicationsTable so TypeScript lint passes when AppSets appear on /applications. Signed-off-by: Asif Draxi <asifdraxi@gmail.com>

ci: retrigger integration tests

fc514e8

Empty commit to re-run flaky race unit test job. Signed-off-by: Asif Draxi <asifdraxi@gmail.com>

nitishfy reviewed May 20, 2026

View reviewed changes

AsifAd requested a review from a team as a code owner May 20, 2026 08:02

AsifAd force-pushed the feat/appset-refresh-ui-27798 branch from d9f76a0 to fc514e8 Compare May 20, 2026 08:06

ppapapetrou76 reviewed May 20, 2026

View reviewed changes

Comment thread server/applicationset/applicationset.go Outdated

AsifAd added a commit to AsifAd/argo-cd that referenced this pull request May 21, 2026

test(appset): cover refresh retry loop and waitSync after update

5629819

Add conflict-retry, exhausted-retry, waitSync, and post-refresh waitSync tests requested in argoproj#27932 review feedback.

AsifAd requested a review from a team as a code owner May 21, 2026 13:57

AsifAd added 2 commits May 21, 2026 19:40

test(appset): cover refresh retry loop and waitSync after update

78836ac

Add conflict-retry, exhausted-retry, waitSync, and post-refresh waitSync tests requested in argoproj#27932 review feedback. Signed-off-by: Asif Draxi <asifdraxi@gmail.com>

AsifAd force-pushed the feat/appset-refresh-ui-27798 branch from 5629819 to 22b937f Compare May 21, 2026 14:10

ppapapetrou76 reviewed May 22, 2026

View reviewed changes

pjiang-dev reviewed May 22, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(appset): add Refresh RPC and UI action (#27798)#27932

feat(appset): add Refresh RPC and UI action (#27798)#27932
AsifAd wants to merge 5 commits into
argoproj:masterfrom
AsifAd:feat/appset-refresh-ui-27798

AsifAd commented May 19, 2026

Uh oh!

bunnyshell Bot commented May 19, 2026 •

edited

Loading

Uh oh!

codecov Bot commented May 19, 2026 •

edited

Loading

Uh oh!

nitishfy left a comment

Uh oh!

AsifAd commented May 20, 2026

Uh oh!

AsifAd commented May 20, 2026

Uh oh!

ppapapetrou76 left a comment

Uh oh!

Uh oh!

AsifAd commented May 21, 2026

Uh oh!

AsifAd commented May 21, 2026

Uh oh!

AsifAd commented May 22, 2026

Uh oh!

ppapapetrou76 left a comment

Uh oh!

ppapapetrou76 May 22, 2026

Uh oh!

pjiang-dev May 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

AsifAd commented May 19, 2026

Summary

Test plan

Uh oh!

bunnyshell Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔴 Preview Environment stopped on Bunnyshell

Uh oh!

codecov Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nitishfy left a comment

Choose a reason for hiding this comment

Uh oh!

AsifAd commented May 20, 2026

Uh oh!

AsifAd commented May 20, 2026

Uh oh!

ppapapetrou76 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

AsifAd commented May 21, 2026

Uh oh!

AsifAd commented May 21, 2026

Uh oh!

AsifAd commented May 22, 2026

Uh oh!

ppapapetrou76 left a comment

Choose a reason for hiding this comment

Uh oh!

ppapapetrou76 May 22, 2026

Choose a reason for hiding this comment

Uh oh!

pjiang-dev May 22, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

bunnyshell Bot commented May 19, 2026 •

edited

Loading

codecov Bot commented May 19, 2026 •

edited

Loading