fix: honor repo depth setting in gitSourceHasChanges and fetch functions (cherry-pick #27838 for 3.3)#28065
Merged
blakepettersson merged 1 commit intoMay 30, 2026
Conversation
…ons (argoproj#27838) Signed-off-by: alexandresavicki <alexandre.savicki@quintoandar.com.br> Co-authored-by: Cursor <cursoragent@cursor.com>
e42277f to
77465f0
Compare
Contributor
Author
|
Hey @blakepettersson, this is a manual cherry-pick of #27838 to release-3.3 (the automatic one failed due to merge conflicts). Could you review and merge when you get a chance? Thanks! |
jesielconceicao
approved these changes
May 29, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-3.3 #28065 +/- ##
===============================================
+ Coverage 62.91% 62.92% +0.01%
===============================================
Files 353 353
Lines 50327 50333 +6
===============================================
+ Hits 31661 31673 +12
+ Misses 15632 15621 -11
- Partials 3034 3039 +5 ☔ View full report in Codecov by Sentry. |
choejwoo
approved these changes
May 30, 2026
blakepettersson
approved these changes
May 30, 2026
Contributor
Author
|
Thanks for the merge @blakepettersson! Any chance a v3.3.12 patch release could be cut soon? We're waiting on this fix to properly use shallow clones in our setup. Happy to help if there's anything needed from my side. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick of #27838 to release-3.3.
The automatic cherry-pick failed due to a merge conflict in
reposerver/repository/repository.gocaused by structural differences betweenmasterandrelease-3.3(therepoLock.Lockcallback signature andcheckoutRevisionparameters differ between branches).The conflict was resolved by adapting the fix to the
release-3.3code structure:checkoutRevision(gitClient, revision, false, 0)→checkoutRevision(gitClient, revision, false, repo.Depth)s.fetch(gitClient, []string{syncedRevision})→s.fetch(gitClient, []string{syncedRevision}, repo.Depth)