TypeChecker: skip external free functions in using for resolution#16719
Open
genisis0x wants to merge 1 commit into
Open
TypeChecker: skip external free functions in using for resolution#16719genisis0x wants to merge 1 commit into
using for resolution#16719genisis0x wants to merge 1 commit into
Conversation
When a free function declared `external` is referenced from a `using for`
directive, SyntaxChecker emits error 4126 ("Free functions cannot have
visibility.") but the error is not fatal, so type checking continues into
endVisit(UsingForDirective). The resolution there calls
`FunctionDefinition::type()` for the non-library branch, which asserts
`visibility() != External` and triggers an ICE.
Skip such entries explicitly under `solAssert(hasErrors())`. The user
still receives the visibility error from the function definition itself,
and the directive no longer reaches the assertion.
Fixes argotorg#16620
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a free function declared `external` is referenced from a `using for` directive, SyntaxChecker emits error 4126 ("Free functions cannot have visibility.") but the error is not fatal, so type checking continues into `endVisit(UsingForDirective)`. The resolution there calls `FunctionDefinition::type()` on the non-library branch, which asserts `visibility() != External` and triggers an ICE.
Skip such entries explicitly under `solAssert(hasErrors())`. The user still receives the visibility error from the function definition itself, and the directive no longer reaches the assertion.
Fixes #16620
Test plan