Include raw bytes instead of include_bytes - #739
Open
patrickmscott wants to merge 1 commit into
Open
Conversation
This avoids a lot of determinism issues with paths in the generated code. It also removes a good amount of code that tries to create relative paths. The core issue is that most paths (config and templates) run through std::path::absolute. However, due to another bazel issue (askama-rs#708), the caller path is relative. Even if that were fixed, macro-in-a-macro (askama-rs#706) would end up using an absolute path.
Collaborator
|
The problem with this approach is that a change in a template won't trigger a rebuild. |
Author
|
Good point. I am using bazel so changes to templates already trigger a rebuild. Any other ideas on how to prevent absolute paths? The current code calls |
Collaborator
|
We could use relative paths in the expanded code I guess and keep the absolute paths for comparisons? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids a lot of determinism issues with paths in the generated code. It also removes a good amount of code that tries to create relative paths.
The core issue is that most paths (config and templates) run through std::path::absolute. However, due to another bazel issue (#708), the caller path is relative. Even if that were fixed, macro-in-a-macro (#706) would end up using an absolute path.