Reject pylock artifacts with mismatched declared sizes#20443
Draft
zanieb wants to merge 1 commit into
Draft
Conversation
zanieb
added
breaking
This comment was marked as low quality.
This comment was marked as low quality.
zanieb
marked this pull request as draft
July 15, 2026 23:45
Member
Author
|
I need to understand this blurb about sizes in the ecosystem first. |
Member
|
I'm fine with checking, and I don't think it's breaking, though wrong sizes don't seem a noticeable problem to me given that we have hashes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
pylock.tomlartifact can declare an incorrectsizeand still install when its hash is correct, despite thepylock.tomlinstallation specification requiring size checks when present. Validate declared sizes for local, remote, and cached wheels, source distributions, and archives before installation, while continuing to treat registry-reported sizes as advisory.This is breaking for locks with stale sizes that were accepted by installers such as pip, which currently leaves file-size validation unimplemented. Regenerate the lock or remove the stale optional
size; pre-existing cache entries without recorded sizes will refresh.