Remove the stdin metadata from uv check#20501
Merged
Merged
Conversation
uv test inventory changesThis PR changes the tests when compared with the
|
zanieb
approved these changes
Jul 18, 2026
Although it was a nice idea that it would simplify config contracts for an mvp, Micha and I agreed it Simply Doesn't Work because in scanning a workspace's files, ty is liable to find PEP-723 scripts, and then it *definitely* needs to call back into uv anyway. So, rather than include two modes, where one maybe works better in simple workspaces with weird flags, we're going to just have the one mode where ty calls back into uv. This does mean we're preserving a bit of unfortunate redundancy, in that we still need to do a sync to get the ty binary to invoke, and then ty will turn around and ask for the sync again... but it's fine, if they were going to be able to reuse the sync then it's gonna be a super cheap resync. The more notable "hole" this opens up is this command now takes various cli flags that ty will not respect when it reinvokes uv. For the MVP we are mostly just going with "that's fine, let's ship and iterate, it's all in preview". The most important settings to forward along should really be persistently saved in config or env-vars, so common things will "just work".
Gankra
enabled auto-merge (squash)
July 20, 2026 14:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Although it was a nice idea that it would simplify config contracts for an mvp, Micha and I agreed it Simply Doesn't Work because in scanning a workspace's files, ty is liable to find PEP-723 scripts, and then it definitely needs to call back into uv anyway.
So, rather than include two modes, where one maybe works better in simple workspaces with weird flags, we're going to just have the one mode where ty calls back into uv.
This does mean we're preserving a bit of unfortunate redundancy, in that we still need to do a sync to get the ty binary to invoke, and then ty will turn around and ask for the sync again... but it's fine, if they were going to be able to reuse the sync then it's gonna be a super cheap resync.
The more notable "hole" this opens up is this command now takes various cli flags that ty will not respect when it reinvokes uv. For the MVP we are mostly just going with "that's fine, let's ship and iterate, it's all in preview".
The most important settings to forward along should really be persistently saved in config or env-vars, so common things will "just work". The most important contradiction to this is IMO
--isolated, especially because we published some docs that suggested it with the precommit hook, that's what #20500 is for.