Skip to content

feat: wire up a global constants file with package version - #1881

Merged
tejaskash merged 2 commits into
aws:refactorfrom
Hweinstock:feat/wire-up-version
Jul 31, 2026
Merged

feat: wire up a global constants file with package version#1881
tejaskash merged 2 commits into
aws:refactorfrom
Hweinstock:feat/wire-up-version

Conversation

@Hweinstock

@Hweinstock Hweinstock commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Problem

The package version is not wired up into telemetry or logging.

Solution

  • define a constants.ts at the top level, import the package.json and extract the version.

Notes

originally thought this wouldn't work on bun executable, but it does! It appears to pull the file in to the executable.

Testing

Ran 3 commands, one from a node build bun run build, one from dev bun run start, and one from exec ./dist/bin/agentcore-linux-x64 . All three produced logs with the correct version number.

@github-actions github-actions Bot added the agentcore-harness-reviewing AgentCore Harness review in progress label Jul 31, 2026
@codecov-commenter

codecov-commenter commented Jul 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.98%. Comparing base (bb14e85) to head (8406a6f).

Additional details and impacted files
@@            Coverage Diff            @@
##           refactor    #1881   +/-   ##
=========================================
  Coverage     95.97%   95.98%           
=========================================
  Files           208      209    +1     
  Lines          9674     9677    +3     
=========================================
+ Hits           9285     9288    +3     
  Misses          389      389           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Hweinstock
Hweinstock force-pushed the feat/wire-up-version branch from 5d373ff to c5b1b08 Compare July 31, 2026 01:47
@github-actions github-actions Bot removed the agentcore-harness-reviewing AgentCore Harness review in progress label Jul 31, 2026
@Hweinstock
Hweinstock marked this pull request as ready for review July 31, 2026 01:50
tejaskash
tejaskash previously approved these changes Jul 31, 2026

@tejaskash tejaskash left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

notgitika
notgitika previously approved these changes Jul 31, 2026
@Hweinstock
Hweinstock dismissed stale reviews from notgitika and tejaskash via 8406a6f July 31, 2026 16:20
@tejaskash
tejaskash merged commit 3798e2e into aws:refactor Jul 31, 2026
8 checks passed
@Hweinstock
Hweinstock deleted the feat/wire-up-version branch July 31, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants