feat: wire up a global constants file with package version - #1881
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## refactor #1881 +/- ##
=========================================
Coverage 95.97% 95.98%
=========================================
Files 208 209 +1
Lines 9674 9677 +3
=========================================
+ Hits 9285 9288 +3
Misses 389 389 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Hweinstock
force-pushed
the
feat/wire-up-version
branch
from
July 31, 2026 01:47
5d373ff to
c5b1b08
Compare
Hweinstock
marked this pull request as ready for review
July 31, 2026 01:50
notgitika
previously approved these changes
Jul 31, 2026
notgitika
approved these changes
Jul 31, 2026
tejaskash
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The package version is not wired up into telemetry or logging.
Solution
Notes
originally thought this wouldn't work on bun executable, but it does! It appears to pull the file in to the executable.
Testing
Ran 3 commands, one from a node build
bun run build, one from devbun run start, and one from exec./dist/bin/agentcore-linux-x64. All three produced logs with the correct version number.